promptflow icon indicating copy to clipboard operation
promptflow copied to clipboard

[BUG] parse of BUILD_INFO failed if not set

Open vsantele opened this issue 1 year ago • 12 comments

Describe the bug With a fresh environment on my computer, my flow raises an error with the tool promptflow_vectordb.tool.common_index_lookup.search. The function _get_custom_dimensions inside promptflow_vectordb\tool\common_index_lookup.py cannot get a build_number because the environment variable BUILD_INFO is not set.

How To Reproduce the bug Steps to reproduce the behavior, how frequent can you experience the bug:

  1. Create a conda environment with python=3.11
  2. Install the lastest version of promptflow (1.16.1), promptflow-tools (1.4.0) and promptflow-vectordb (0.2.13)
  3. Create a flow using promptflow_vectordb.tool.common_index_lookup.search with a FAISS index from Azure ML (I didn't test with other options)
  4. Run the flow

Expected behavior The index lookup has to work without the BUILD_INFO. It has to have fallback build_number if the environment variable is not set.

Running Information(please complete the following information):

  • Promptflow Package Version using pf -v:
{
  "promptflow": "1.16.1",
  "promptflow-azure": "1.16.1",
  "promptflow-core": "1.16.1",
  "promptflow-devkit": "1.16.1",
  "promptflow-tracing": "1.16.1"
}
promtflow-vectordb===0.2.13
promptflow-tools===1.4.0
  • Operating System: Windows 11
  • Python Version using python --version: python==3.11.10

Additional context There are discussions at #3632 with this error, but it was not the main topic and the issue is closed.

vsantele avatar Oct 30 '24 00:10 vsantele

The requirement of this ENV should be documented or made optional. I've spend to many hours on finding this problem. I think many others with me.

ferronsw avatar Nov 07 '24 11:11 ferronsw

Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you!

github-actions[bot] avatar Dec 07 '24 21:12 github-actions[bot]

Up. What kind of information do you need?

vsantele avatar Dec 08 '24 15:12 vsantele

The source code of promptflow-vectordb is not available. So we cannot fix or make a PR for this.

Inside this repository, there is already a fix to fall back to a default value if BUILD_INFO is not set up.

https://github.com/microsoft/promptflow/blob/40c84b46f48cc7d02b6188e244e3dd8b0dde4743/src/promptflow-core/promptflow/core/_serving/v1/app.py#L134-L139

The fix is very easy. Is there another way to ask for a fix?

vsantele avatar Dec 11 '24 12:12 vsantele

promptflow-vectordb has been updated twice since October, but the bug is still there.

Is there another way to contact the team in charge of promptflow-vectordb?

vsantele avatar Jan 05 '25 13:01 vsantele

I've run into the same issue after launching a vs code container from azure ai foundry. Is there a workaround for this?

hirdayeshbshrestha avatar Jan 29 '25 19:01 hirdayeshbshrestha

@hirdayeshbshrestha You need to set an environment variable BUILD_INFO like this:

BUILD_INFO='{"build_number":0}'

I don't know a good workaround for vscode container. However, you can set it before using the pf cli in a terminal. Or try to set a global environment variable.

We cannot contribute to promtflow-vectordb, so there is no real solution.

vsantele avatar Jan 29 '25 19:01 vsantele

There have been several updates since the issue was created. The bug is still present in promptflow 1.17.2 and promptflow-vectordb 0.2.16 if we set PF_DISABLE_TRACING="false".

vsantele avatar Feb 03 '25 12:02 vsantele

Just a comment to not be closed by the bot

vsantele avatar Feb 21 '25 20:02 vsantele

Another comment to not be closed by the bot

vsantele avatar Mar 19 '25 18:03 vsantele

Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you!

github-actions[bot] avatar Apr 18 '25 21:04 github-actions[bot]

A new another comment to not be closed by the bot. Time flies!

vsantele avatar Apr 19 '25 09:04 vsantele

Another comment to not be closed by the bot.

Will the promptflow-vectordb source code be open source at some point? It's an easy fix for a really annoying bug in the local environment.

vsantele avatar May 15 '25 15:05 vsantele

A new another comment to not be closed by the bot.

I know this bug is not directly related with this repo. But promptflow-vectordb is not open source.

vsantele avatar Jun 09 '25 21:06 vsantele

Same issue with preview version of vscode plugin, same flow works fine in web in AzureML. Using AI Search

GitRik avatar Jun 26 '25 13:06 GitRik

Another comment to prevent the bot from closing the issue

vsantele avatar Jul 23 '25 16:07 vsantele

Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you!

github-actions[bot] avatar Aug 22 '25 21:08 github-actions[bot]

No new version of promptflow-vectordb since last month. I assume the bug is still present

vsantele avatar Aug 22 '25 21:08 vsantele

Hi, we're sending this friendly reminder because we haven't heard back from you in 30 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 7 days of this comment, the issue will be automatically closed. Thank you!

github-actions[bot] avatar Sep 23 '25 21:09 github-actions[bot]

The issue still exists

vsantele avatar Oct 14 '25 07:10 vsantele