promptflow icon indicating copy to clipboard operation
promptflow copied to clipboard

Refactor: remove unnecessary code from flow_executor.py

Open hiroki0525 opened this issue 1 year ago • 6 comments

Description

I have found that they are not used in the current code in flow_executor.py. Perhaps they were forgotten to be removed in past changes.

All Promptflow Contribution checklist:

  • [x] The pull request does not introduce [breaking changes].
  • [x] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [x] I have read the contribution guidelines.
  • [x] I confirm that all new dependencies are compatible with the MIT license.
  • [x] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • [x] Title of the pull request is clear and informative.
  • [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [x] Pull request includes test coverage for the included changes.

hiroki0525 avatar Aug 11 '24 00:08 hiroki0525

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Aug 30 '24 21:08 github-actions[bot]

@microsoft/promptflow-sdk Excuse me, when can I have a review?

hiroki0525 avatar Aug 31 '24 04:08 hiroki0525

SDK CLI Global Config Test Result remove-unnecessary-code

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 8a4f9f69.

github-actions[bot] avatar Sep 15 '24 13:09 github-actions[bot]

Executor E2E Test Result remove-unnecessary-code

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 8a4f9f69.

github-actions[bot] avatar Sep 15 '24 13:09 github-actions[bot]

Executor Unit Test Result remove-unnecessary-code

0 tests   0 :white_check_mark:  0s :stopwatch: 0 suites  0 :zzz: 0 files    0 :x:

Results for commit 8a4f9f69.

github-actions[bot] avatar Sep 15 '24 13:09 github-actions[bot]

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Sep 29 '24 21:09 github-actions[bot]

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar Oct 07 '24 21:10 github-actions[bot]