promptflow icon indicating copy to clipboard operation
promptflow copied to clipboard

[Internal] Add comment to be mindful to move refresh_connections_dir function to elsewhere

Open 16oeahr opened this issue 1 year ago • 6 comments

Add comment to take care to move refresh_connections_dir function to elsewhere

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • [X] The pull request does not introduce [breaking changes].
  • [ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [X] I have read the contribution guidelines.
  • [ ] I confirm that all new dependencies are compatible with the MIT license.
  • [ ] Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • [X] Title of the pull request is clear and informative.
  • [X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • [ ] Pull request includes test coverage for the included changes.

16oeahr avatar Jul 26 '24 03:07 16oeahr

promptflow SDK CLI Azure E2E Test Result user/yalu4/add_comment

  4 files    4 suites   4m 16s :stopwatch: 244 tests 204 :white_check_mark:  40 :zzz: 0 :x: 976 runs  816 :white_check_mark: 160 :zzz: 0 :x:

Results for commit 880a3cb0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 26 '24 03:07 github-actions[bot]

SDK CLI Global Config Test Result user/yalu4/add_comment

6 tests   6 :white_check_mark:  1m 22s :stopwatch: 1 suites  0 :zzz: 1 files    0 :x:

Results for commit 880a3cb0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 26 '24 03:07 github-actions[bot]

Executor Unit Test Result user/yalu4/add_comment

798 tests   798 :white_check_mark:  3m 44s :stopwatch:   1 suites    0 :zzz:   1 files      0 :x:

Results for commit 880a3cb0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 26 '24 03:07 github-actions[bot]

Executor E2E Test Result user/yalu4/add_comment

246 tests   240 :white_check_mark:  5m 3s :stopwatch:   1 suites    6 :zzz:   1 files      0 :x:

Results for commit 880a3cb0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 26 '24 03:07 github-actions[bot]

SDK CLI Test Result user/yalu4/add_comment

    4 files      4 suites   1h 7m 11s :stopwatch:   786 tests   763 :white_check_mark: 23 :zzz: 0 :x: 3 144 runs  3 052 :white_check_mark: 92 :zzz: 0 :x:

Results for commit 880a3cb0.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 26 '24 04:07 github-actions[bot]

Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment.

github-actions[bot] avatar Aug 12 '24 21:08 github-actions[bot]

Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

github-actions[bot] avatar Aug 19 '24 21:08 github-actions[bot]