presidio icon indicating copy to clipboard operation
presidio copied to clipboard

SpacyRecognizer: List of Tuples for check label groups argument

Open dhruvmullick opened this issue 2 years ago • 3 comments

https://github.com/microsoft/presidio/blob/aa50e6bbcd8bef6c0281c7c0eb1b354bc20ae55e/presidio-analyzer/presidio_analyzer/predefined_recognizers/spacy_recognizer.py#L53

I believe this should be Optional[List[Tuple[Set, Set]]]. This would let us support multiple tuples like is the default case with self.CHECK_LABEL_GROUPS.

dhruvmullick avatar Dec 14 '22 23:12 dhruvmullick

Thanks, you are correct. We'll address that sometime soon, feel free to create a PR if interested.

omri374 avatar Dec 17 '22 19:12 omri374

Sure, will take this up. @omri374 , can you give me write access for the PR?

dhruvmullick avatar Dec 17 '22 20:12 dhruvmullick

@dhruvmullick please fork the repo and create a PR from the fork

omri374 avatar Dec 18 '22 07:12 omri374