presidio icon indicating copy to clipboard operation
presidio copied to clipboard

Integrate Presidio CLI

Open walkowif opened this issue 2 years ago • 11 comments

Change Description

Integrate Presidio CLI into Presidio repository.

Issue reference

This PR fixes issue https://github.com/microsoft/presidio/issues/885

Checklist

  • [X] I have reviewed the contribution guidelines
  • [x] I have signed the CLA
  • [X] My code includes unit tests
  • [ ] All unit tests and lint checks pass locally
  • [X] My PR contains documentation updates / additions if required

walkowif avatar Sep 20 '22 12:09 walkowif

CLA assistant check
All CLA requirements met.

ghost avatar Sep 20 '22 12:09 ghost

FYI @cicdguy

walkowif avatar Sep 20 '22 12:09 walkowif

Thank you for the amazing contribution. We will review the PR soon. Could you please sign the CLA?

omri374 avatar Sep 21 '22 15:09 omri374

/azp run

omri374 avatar Sep 21 '22 15:09 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 21 '22 15:09 azure-pipelines[bot]

/azp run

balteravishay avatar Sep 22 '22 09:09 balteravishay

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 22 '22 09:09 azure-pipelines[bot]

@omri374 I have signed the CLA.

walkowif avatar Sep 22 '22 13:09 walkowif

Command 'urn' is not supported by Azure Pipelines.

Supported commands

  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

azure-pipelines[bot] avatar Oct 06 '22 18:10 azure-pipelines[bot]

/azp run

omri374 avatar Oct 06 '22 18:10 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 06 '22 18:10 azure-pipelines[bot]

@omri374 Thanks for the comments. Next week my availability will be limited but I'll try to resolve the comments in the week after.

walkowif avatar Oct 14 '22 16:10 walkowif

Thank you @walkowif!

omri374 avatar Oct 14 '22 17:10 omri374

@microsoft-github-policy-service agree [company="F. Hoffmann-La Roche AG"]

walkowif avatar Oct 24 '22 15:10 walkowif

@microsoft-github-policy-service agree company="F. Hoffmann-La Roche AG"

walkowif avatar Oct 24 '22 15:10 walkowif

@shiranr @omri374 - Anything we can do to expedite this PR so we can begin Phase 2 implementations?

cicdguy avatar Nov 02 '22 12:11 cicdguy

@cicdguy we'll make sure it is finalized. One open point is the release to PyPI. If we want to have the CLI released with the other Presidio modules, we would probably need to configure that. We can tackle that after this PR if it's easier. cc @shiranr @navalev

omri374 avatar Nov 02 '22 12:11 omri374

/azp run

omri374 avatar Nov 02 '22 14:11 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 02 '22 14:11 azure-pipelines[bot]

@walkowif there's a small linting error: https://dev.azure.com/csedevil/Presidio/_build/results?buildId=14530&view=logs&j=7f4c3047-489f-5549-b798-6150d7f6e0e6&t=9d5524d0-6b47-5000-e72d-4cb98852868e&l=16

omri374 avatar Nov 02 '22 14:11 omri374

@omri374 Should be okay now.

walkowif avatar Nov 02 '22 15:11 walkowif

/azp run

omri374 avatar Nov 02 '22 17:11 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 02 '22 17:11 azure-pipelines[bot]

/azp run

omri374 avatar Nov 03 '22 10:11 omri374

@walkowif I updated the Pipfile.lock file on your fork, as it was using an old version of Presidio. Feel free to overwrite that if I got it wrong.

omri374 avatar Nov 03 '22 10:11 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 03 '22 10:11 azure-pipelines[bot]