presidio
presidio copied to clipboard
Integrate Presidio CLI
Change Description
Integrate Presidio CLI into Presidio repository.
Issue reference
This PR fixes issue https://github.com/microsoft/presidio/issues/885
Checklist
- [X] I have reviewed the contribution guidelines
- [x] I have signed the CLA
- [X] My code includes unit tests
- [ ] All unit tests and lint checks pass locally
- [X] My PR contains documentation updates / additions if required
FYI @cicdguy
Thank you for the amazing contribution. We will review the PR soon. Could you please sign the CLA?
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@omri374 I have signed the CLA.
Command 'urn' is not supported by Azure Pipelines.
Supported commands
- help:
- Get descriptions, examples and documentation about supported commands
- Example: help "command_name"
- list:
- List all pipelines for this repository using a comment.
- Example: "list"
- run:
- Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
- Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
- where:
- Report back the Azure DevOps orgs that are related to this repository and org
- Example: "where"
See additional documentation.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@omri374 Thanks for the comments. Next week my availability will be limited but I'll try to resolve the comments in the week after.
Thank you @walkowif!
@microsoft-github-policy-service agree [company="F. Hoffmann-La Roche AG"]
@microsoft-github-policy-service agree company="F. Hoffmann-La Roche AG"
@shiranr @omri374 - Anything we can do to expedite this PR so we can begin Phase 2 implementations?
@cicdguy we'll make sure it is finalized. One open point is the release to PyPI. If we want to have the CLI released with the other Presidio modules, we would probably need to configure that. We can tackle that after this PR if it's easier. cc @shiranr @navalev
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@walkowif there's a small linting error: https://dev.azure.com/csedevil/Presidio/_build/results?buildId=14530&view=logs&j=7f4c3047-489f-5549-b798-6150d7f6e0e6&t=9d5524d0-6b47-5000-e72d-4cb98852868e&l=16
@omri374 Should be okay now.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
@walkowif I updated the Pipfile.lock file on your fork, as it was using an old version of Presidio. Feel free to overwrite that if I got it wrong.
Azure Pipelines successfully started running 1 pipeline(s).