presidio icon indicating copy to clipboard operation
presidio copied to clipboard

GSTIN(Goods and Service Tax Identification Number,India) Recognizer is not found

Open HarikrishnanK9 opened this issue 6 months ago • 18 comments

Change Description

Describe your changes

Issue reference

This PR fixes issue #XX

Checklist

  • [x] I have reviewed the contribution guidelines
  • [x] I have signed the CLA (if required)
  • [x] My code includes unit tests
  • [x] All unit tests and lint checks pass locally
  • [x] My PR contains documentation updates / additions if required

HarikrishnanK9 avatar Jun 03 '25 08:06 HarikrishnanK9

@HarikrishnanK9 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

HarikrishnanK9 avatar Jun 03 '25 08:06 HarikrishnanK9

Thanks for your contribution! Could you please add unit tests and add it to the default recognizers list?

https://github.com/microsoft/presidio/blob/main/presidio-analyzer/presidio_analyzer/conf/default_recognizers.yaml

omri374 avatar Jun 04 '25 12:06 omri374

/azp run

omri374 avatar Jun 04 '25 12:06 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 04 '25 12:06 azure-pipelines[bot]

Thank you @omri374 I have added the test case and updated the conf. Please let me know if any changes are required from my side.

HarikrishnanK9 avatar Jun 04 '25 16:06 HarikrishnanK9

@omri374 I have updated the file with the changes suggested. Could you please review it to ensure it meets the requirements

HarikrishnanK9 avatar Jun 06 '25 04:06 HarikrishnanK9

/azp run

omri374 avatar Jun 06 '25 09:06 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 06 '25 09:06 azure-pipelines[bot]

/azp run

omri374 avatar Jun 09 '25 12:06 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 09 '25 12:06 azure-pipelines[bot]

/azp run

omri374 avatar Jun 10 '25 20:06 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 10 '25 20:06 azure-pipelines[bot]

/azp run

omri374 avatar Jun 17 '25 06:06 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 17 '25 06:06 azure-pipelines[bot]

Hello @omri374, I noticed my pull request was approved, and I'm really excited about contributing to Presidio. Could you let me know if there are any remaining steps, or if I need to update anything before it gets merged? Thank you for your time. I'm waiting for the merge

HarikrishnanK9 avatar Jun 23 '25 04:06 HarikrishnanK9

Hi @HarikrishnanK9, thanks! Please review the outcomes of the CI. Some tests are failing.

omri374 avatar Jun 23 '25 06:06 omri374

/azp run

omri374 avatar Jun 23 '25 06:06 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 23 '25 06:06 azure-pipelines[bot]

/azp run

omri374 avatar Jul 13 '25 12:07 omri374

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jul 13 '25 12:07 azure-pipelines[bot]

Closing due to no response from author. Feel free to reopen it you wish to continue working on this.

omri374 avatar Jul 13 '25 17:07 omri374

gstin implemented in #1744

omri374 avatar Oct 16 '25 06:10 omri374