GSTIN(Goods and Service Tax Identification Number,India) Recognizer is not found
Change Description
Describe your changes
Issue reference
This PR fixes issue #XX
Checklist
- [x] I have reviewed the contribution guidelines
- [x] I have signed the CLA (if required)
- [x] My code includes unit tests
- [x] All unit tests and lint checks pass locally
- [x] My PR contains documentation updates / additions if required
@HarikrishnanK9 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"Contributor License Agreement
@microsoft-github-policy-service agree
Thanks for your contribution! Could you please add unit tests and add it to the default recognizers list?
https://github.com/microsoft/presidio/blob/main/presidio-analyzer/presidio_analyzer/conf/default_recognizers.yaml
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Thank you @omri374 I have added the test case and updated the conf. Please let me know if any changes are required from my side.
@omri374 I have updated the file with the changes suggested. Could you please review it to ensure it meets the requirements
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Hello @omri374, I noticed my pull request was approved, and I'm really excited about contributing to Presidio. Could you let me know if there are any remaining steps, or if I need to update anything before it gets merged? Thank you for your time. I'm waiting for the merge
Hi @HarikrishnanK9, thanks! Please review the outcomes of the CI. Some tests are failing.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
Closing due to no response from author. Feel free to reopen it you wish to continue working on this.
gstin implemented in #1744