playwright icon indicating copy to clipboard operation
playwright copied to clipboard

chore: use a single Progress instance for expect

Open dgozman opened this issue 6 months ago • 1 comments

In the new strict progress mode, we can skip progress.race() calls and thus avoid being interrupted by the progress.

To support legacy mode, guarded by env.PLAYWRIGHT_LEGACY_TIMEOUTS, two new methods progress.pause() and progress.resume() are implemented. This will go away as soon as legacy mode is removed.

Closes #36236. References #35987.

dgozman avatar Jun 23 '25 13:06 dgozman

Test results for "tests 1"

1 failed :x: [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @webkit-ubuntu-22.04-node18

6 flaky :warning: [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
:warning: [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
:warning: [chromium] › headerView.spec.tsx:46:1 › should toggle filters @web-components-html-reporter
:warning: [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39453 passed, 823 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Jun 23 '25 14:06 github-actions[bot]

Test results for "tests 1"

3 failed :x: [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1 :x: [playwright-test] › reporter-html.spec.ts:2890:5 › created › execSync doesnt produce a second stdout attachment @macos-latest-node18-2 :x: [webkit-library] › library/video.spec.ts:411:5 › screencast › should capture css transformation @webkit-ubuntu-22.04-node18

4 flaky :warning: [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
:warning: [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39465 passed, 823 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Jun 24 '25 19:06 github-actions[bot]