bug(network): Use proxySocket to determine alpnProtocol

[Zemotacqy]

Fixes: https://github.com/microsoft/playwright/issues/34873

References: https://github.com/microsoft/playwright/pull/34939

• Use proxy(if applicable) & secureContext for origin in ALPN

[Zemotacqy]

@microsoft-github-policy-service agree company="BrowserStack"

[github-actions[bot]]

Test results for "tests 1"

28 passed :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[github-actions[bot]]

Test results for "tests 1"

5 flaky

:warning: [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
:warning: [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
:warning: [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
:warning: [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39240 passed, 804 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[Zemotacqy]

Hey @mxschmitt , Could you please help here with a review? TIA

[github-actions[bot]]

Test results for "tests 1"

4 failed :x: [playwright-test] › reporter-html.spec.ts:2859:5 › merged › execSync doesnt produce a second stdout attachment @macos-latest-node18-2 :x: [default] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension :x: [default-reuse] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension :x: [default-trace] › run-tests.spec.ts:1305:5 › should provide page snapshot to copilot @vscode-extension

4 flaky

:warning: [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
:warning: [chromium-library] › library/video.spec.ts:379:5 › screencast › should capture navigation @ubuntu-22.04-chromium-tip-of-tree
:warning: [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
:warning: [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18

39229 passed, 804 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[Zemotacqy]

Hey @yury-s || @mxschmitt , Can you please take a look at the latest changes. Have handled the secureConnect event incase of proxy requests. Let me know if the approach makes sense.

[github-actions[bot]]

Test results for "tests 1"

1 failed :x: [webkit-library] › library/screenshot.spec.ts:55:14 › page screenshot › should work with a mobile viewport and clip @webkit-ubuntu-22.04-node18

10 flaky

:warning: [chromium-library] › library/browsercontext-reuse.spec.ts:256:1 › should work with clock emulation @chromium-ubuntu-22.04-node18
:warning: [chromium-library] › library/browsercontext-reuse.spec.ts:256:1 › should work with clock emulation @chromium-ubuntu-22.04-node20
:warning: [chromium-library] › library/browsercontext-reuse.spec.ts:256:1 › should work with clock emulation @chromium-ubuntu-22.04-node22
:warning: [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
:warning: [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-trace.spec.ts:587:5 › should indicate current test status @macos-latest-node18-1
:warning: [chromium-library] › library/browsercontext-reuse.spec.ts:256:1 › should work with clock emulation @ubuntu-22.04-chromium-tip-of-tree
:warning: [chromium] › headerView.spec.tsx:46:1 › should toggle filters @web-components-html-reporter
:warning: [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39285 passed, 818 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[Zemotacqy]

Hey folks, Can someone please take a look?

[Zemotacqy]

Hey @yury-s || @mxschmitt Can you please review latest changes ? Do let me know if the approach sounds good.

Thanks in Advance

[github-actions[bot]]

Test results for "tests 1"

4 flaky

:warning: [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
:warning: [chromium-library] › library/inspector/cli-codegen-pick-locator.spec.ts:35:7 › should update locator highlight @ubuntu-22.04-chromium-tip-of-tree
:warning: [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39366 passed, 820 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[Zemotacqy]

Hey @pavelfeldman, Apologies for noise here. Do you think if I raise a fresh PR, it would help with the review. Happy to continue working on this PR.

[pavelfeldman]

My understanding is that there is an upcoming change in the existing implementation that is supposed to address this. I'll assign the issue to 1.55

[mxschmitt]

Update posted in https://github.com/microsoft/playwright/issues/34873#issuecomment-3144370316.