playwright icon indicating copy to clipboard operation
playwright copied to clipboard

[Feature]: More precise Webkit version in changelog

Open dimkin-eu opened this issue 9 months ago • 4 comments

🚀 Feature Request

now both 1.49 and 1.50 have WebKit 18.2 in the changelog, but they are very different under the hood. Is there a way to add which exactly tech preview version is bundled?

Image

Example

No response

Motivation

Eliminating uncertainty about which version is being used.

dimkin-eu avatar Jan 30 '25 11:01 dimkin-eu

also, when pw downloads new browser version - some random number is shown

Downloading Webkit 18.2 (playwright build v2123) from https://cdn.playwright.dev/dbazure/download/playwright/builds/webkit/2123/webkit-mac-15.zip
68.6 MiB [====================] 100% 0.0s
Webkit 18.2 (playwright build v2123) downloaded to /Users/foobar/Library/Caches/ms-playwright/webkit-2123

I have feeling this is https://webkit.org/blog/16445/release-notes-for-safari-technology-preview-212/ but maybe I'm wrong

dimkin-eu avatar Jan 30 '25 11:01 dimkin-eu

Our WebKit version does not correspond directly to a Technology Preview but instead is based off of a particular commit at the point in time when we roll the browser. The Playwright build number is our version number as we must build versions of the browser with slight tweaks.

Would providing the source commit for WebKit be sufficient to your usecase?

agg23 avatar Jan 30 '25 14:01 agg23

at least that much :)

dimkin-eu avatar Jan 30 '25 14:01 dimkin-eu

I would appreciate a link to WebKit project where the last commit was taken. E.g. in Playwright 1.50, WebKit started to be unresponsive in one of our tests opening URLs that are present on a page, one by one and from the version WebKit 18.2 I can't recognize what changed.

mirao avatar Jan 31 '25 06:01 mirao

Why was this issue closed?

Thank you for your involvement. This issue was closed due to limited engagement (upvotes/activity), lack of recent activity, and insufficient actionability. To maintain a manageable database, we prioritize issues based on these factors.

If you disagree with this closure, please open a new issue and reference this one. More support or clarity on its necessity may prompt a review. Your understanding and cooperation are appreciated.

pavelfeldman avatar Sep 04 '25 01:09 pavelfeldman