playwright icon indicating copy to clipboard operation
playwright copied to clipboard

fix: validate ffmpeg on context creation

Open mxschmitt opened this issue 1 year ago • 1 comments

Instead of massaging the signal handling so that the first page creation would notify the context I think it might be better to just validate if ffmpeg is there when we create the context.

Resolves https://github.com/microsoft/playwright/issues/33899

mxschmitt avatar Dec 07 '24 04:12 mxschmitt

Test results for "tests 1"

2 flaky :warning: [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37201 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 07 '24 05:12 github-actions[bot]

Test results for "tests 1"

15 passed :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 10 '24 01:12 github-actions[bot]

Test results for "tests 1"

1 failed :x: [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

2 flaky :warning: [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
:warning: [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @ubuntu-20.04-chromium-tip-of-tree

37200 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 10 '24 02:12 github-actions[bot]

Test results for "tests 1"

2 flaky :warning: [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37201 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 10 '24 19:12 github-actions[bot]

Test results for "tests 1"

3 failed :x: [installation tests] › playwright-cli-install-should-work.spec.ts:99:5 › should print error if recording video without ffmpeg @package-installations-macos-latest :x: [installation tests] › playwright-cli-install-should-work.spec.ts:99:5 › should print error if recording video without ffmpeg @package-installations-ubuntu-latest :x: [installation tests] › playwright-cli-install-should-work.spec.ts:99:5 › should print error if recording video without ffmpeg @package-installations-windows-latest

2 flaky :warning: [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
:warning: [installation tests] › playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-macos-latest

37248 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 11 '24 01:12 github-actions[bot]

Test results for "tests 1"

10 failed :x: [installation tests] › npx-global.spec.ts:34:5 › npx playwright install global @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright.azureedge.net/dbazure/download/playwright) @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright.download.prss.microsoft.com/dbazure/download/playwright) @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright.azureedge.net) @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright-akamai.azureedge.net) @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright-verizon.azureedge.net) @package-installations-macos-latest :x: [installation tests] › playwright-cli-install-should-work.spec.ts:21:5 › install command should work @package-installations-macos-latest :x: [installation tests] › playwright-packages-install-behavior.spec.ts:66:5 › playwright should work @package-installations-macos-latest :x: [installation tests] › playwright-packages-install-behavior.spec.ts:88:5 › playwright should work with chromium --only-shell @package-installations-macos-latest :x: [installation tests] › playwright-packages-install-behavior.spec.ts:97:5 › @playwright/test should work @package-installations-macos-latest

1 flaky :warning: [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-22.04-node18

37136 passed, 646 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 12 '24 03:12 github-actions[bot]

Test results for "tests 1"

10 failed :x: [installation tests] › npx-global.spec.ts:34:5 › npx playwright install global @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright.azureedge.net/dbazure/download/playwright) @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright.download.prss.microsoft.com/dbazure/download/playwright) @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright.azureedge.net) @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright-akamai.azureedge.net) @package-installations-macos-latest :x: [installation tests] › playwright-cdn.spec.ts:43:7 › playwright cdn failover should work (https://playwright-verizon.azureedge.net) @package-installations-macos-latest :x: [installation tests] › playwright-cli-install-should-work.spec.ts:21:5 › install command should work @package-installations-macos-latest :x: [installation tests] › playwright-packages-install-behavior.spec.ts:66:5 › playwright should work @package-installations-macos-latest :x: [installation tests] › playwright-packages-install-behavior.spec.ts:88:5 › playwright should work with chromium --only-shell @package-installations-macos-latest :x: [installation tests] › playwright-packages-install-behavior.spec.ts:97:5 › @playwright/test should work @package-installations-macos-latest

2 flaky :warning: [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-22.04-node18
:warning: [installation tests] › playwright-component-testing.spec.ts:55:5 › pnpm: JSX inside a @playwright/test should work @package-installations-macos-latest

37135 passed, 646 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 12 '24 04:12 github-actions[bot]

Test results for "tests 1"

1 failed :x: [installation tests] › playwright-cli-install-should-work.spec.ts:99:5 › should print error if recording video without ffmpeg @package-installations-windows-latest

3 flaky :warning: [firefox-page] › page/page-event-request.spec.ts:169:3 › should return response body when Cross-Origin-Opener-Policy is set @firefox-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37249 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 12 '24 05:12 github-actions[bot]

Test results for "tests 1"

1 failed :x: [installation tests] › playwright-cli-install-should-work.spec.ts:99:5 › should print error if recording video without ffmpeg @package-installations-windows-latest

1 flaky :warning: [chromium-page] › page/page-event-popup.spec.ts:149:3 › should not treat navigations as new popups @chromium-ubuntu-22.04-node22

37251 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 12 '24 06:12 github-actions[bot]

Test results for "tests 1"

4 flaky :warning: [installation tests] › playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-macos-latest
:warning: [chromium-library] › library/trace-viewer.spec.ts:701:1 › should handle multiple headers @ubuntu-20.04-chromium-tip-of-tree
:warning: [webkit-library] › library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37249 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 12 '24 07:12 github-actions[bot]