playwright icon indicating copy to clipboard operation
playwright copied to clipboard

[Bug]: Stuck if there is no ffmpeg in launchPersistentContext / electron

Open mxschmitt opened this issue 1 year ago • 0 comments

When recording a video with launchPersistentContext / electron with enabled video it hangs instead of throws an error that ffmpeg is missing.

Problem is that we wait for the page here:

https://github.com/microsoft/playwright/blob/b3a82bef46e6f704312c441eea17a6bd737c1302/packages/playwright-core/src/server/browserContext.ts#L365

and receive an error here:

https://github.com/microsoft/playwright/blob/4696dd8682be4f644602a89594945e8b0f8f162c/packages/playwright-core/src/server/chromium/crPage.ts#L124

So we should wire

https://github.com/microsoft/playwright/blob/main/packages/playwright-core/src/server/page.ts#L205

together with when we wait for the error./

mxschmitt avatar Dec 06 '24 17:12 mxschmitt