playwright icon indicating copy to clipboard operation
playwright copied to clipboard

fix(defineConfig): fix type issue passing custom property in the seco…

Open yangsisi0422 opened this issue 1 year ago • 6 comments

…nd config param in defineConfig function

To fix TS error: Object literal may only specify known properties, and customOption does not exist in type

When playwright.config.ts as follow:

 type Options = {
  customOption: any[]
}

export default defineConfig<Options>(BasePlaywrightConfig, {
  use: {
    customOption,
  },
})

yangsisi0422 avatar Nov 27 '24 07:11 yangsisi0422

Test results for "tests 1"

1 flaky :warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37173 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 27 '24 08:11 github-actions[bot]

Test results for "tests 1"

5395 passed, 28 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 29 '24 09:11 github-actions[bot]

Test results for "tests 1"

1 failed :x: [webkit-page] › page/page-leaks.spec.ts:82:5 › click should not leak @webkit-ubuntu-22.04-node18

3 flaky :warning: [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node20
:warning: [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
:warning: [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup @ubuntu-20.04-chromium-tip-of-tree

37187 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 29 '24 09:11 github-actions[bot]

@yangsisi0422 This PR looks great! However, I can only merge it after you agree with the CLA - please see this comment. Thank you!

dgozman avatar Dec 03 '24 18:12 dgozman

@yangsisi0422 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

yangsisi0422 avatar Dec 04 '24 00:12 yangsisi0422

Test results for "tests 1"

1 flaky :warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37196 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 04 '24 01:12 github-actions[bot]