playwright icon indicating copy to clipboard operation
playwright copied to clipboard

feat(html): link from attachment step to attachment

Open Skn0tt opened this issue 1 year ago • 14 comments

Similar to https://github.com/microsoft/playwright/pull/33265. Adds a link from the attachment step to the attachment view.

Skn0tt avatar Oct 24 '24 12:10 Skn0tt

Test results for "tests 1"

26306 passed, 434 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Oct 24 '24 12:10 github-actions[bot]

demo:

https://github.com/user-attachments/assets/92eb6252-8c1a-4df4-8bc4-db2902bf55ca

Skn0tt avatar Oct 24 '24 12:10 Skn0tt

Test results for "tests 1"

1 flaky :warning: [playwright-test] › ui-mode-test-ct.spec.ts:155:5 › should watch test @ubuntu-latest-node18-1

36687 passed, 626 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Oct 24 '24 13:10 github-actions[bot]

Test results for "tests 1"

1 failed :x: [webkit-page] › page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18

1 flaky :warning: [playwright-test] › ui-mode-test-setup.spec.ts:22:5 › should run global setup and teardown @ubuntu-latest-node22-1

36686 passed, 626 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Oct 25 '24 08:10 github-actions[bot]

Test results for "tests 1"

1 flaky :warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

36687 passed, 626 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Oct 25 '24 14:10 github-actions[bot]

Test results for "tests 1"

1 failed :x: [playwright-test] › playwright.trace.spec.ts:137:5 › should not throw with trace: on-first-retry and two retries in the same worker @macos-latest-node18-1

1 flaky :warning: [installation tests] › playwright-electron-should-work.spec.ts:31:5 › electron should work with special characters in path @package-installations-macos-latest

36816 passed, 678 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 06 '24 10:11 github-actions[bot]

I've updated this PR to use the Anchor primitive we added in https://github.com/microsoft/playwright/pull/33537.

Skn0tt avatar Nov 19 '24 16:11 Skn0tt

Test results for "tests 1"

10 failed :x: [playwright-test] › reporter-html.spec.ts:919:5 › merged › should link from attach step to attachment view @macos-latest-node18-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › created › should link from attach step to attachment view @macos-latest-node18-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › merged › should link from attach step to attachment view @ubuntu-latest-node18-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › created › should link from attach step to attachment view @ubuntu-latest-node18-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › merged › should link from attach step to attachment view @ubuntu-latest-node20-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › created › should link from attach step to attachment view @ubuntu-latest-node20-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › merged › should link from attach step to attachment view @ubuntu-latest-node22-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › created › should link from attach step to attachment view @ubuntu-latest-node22-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › merged › should link from attach step to attachment view @windows-latest-node18-2 :x: [playwright-test] › reporter-html.spec.ts:919:5 › created › should link from attach step to attachment view @windows-latest-node18-2

3 flaky :warning: [playwright-test] › ui-mode-test-setup.spec.ts:98:5 › should show errors in config @macos-latest-node18-1
:warning: [installation tests] › playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-macos-latest
:warning: [chromium-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @ubuntu-20.04-chromium-tip-of-tree

36950 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 19 '24 17:11 github-actions[bot]

sorry, i'll need to look more into this to make links to trace etc work

Skn0tt avatar Nov 19 '24 17:11 Skn0tt

Here's a demo of it working:

https://github.com/user-attachments/assets/af3259a8-d3b7-4c10-861e-1e51f7b1e86c

Skn0tt avatar Nov 20 '24 09:11 Skn0tt

Test results for "tests 1"

6778 passed, 36 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 20 '24 09:11 github-actions[bot]

Test results for "tests 1"

1 failed :x: [webkit-page] › page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18

2 flaky :warning: [playwright-test] › ui-mode-test-update.spec.ts:83:5 › should pick new / deleted tests @ubuntu-latest-node20-1
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37138 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 20 '24 10:11 github-actions[bot]

Test results for "tests 1"

1 failed :x: [webkit-page] › page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18

1 flaky :warning: [playwright-test] › ui-mode-test-output.spec.ts:80:5 › should show console messages for test @macos-latest-node18-1

37139 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 20 '24 16:11 github-actions[bot]

Test results for "tests 1"

3 flaky :warning: [chromium] › components/splitView.spec.tsx:35:5 › should render sidebar first @web-components-web
:warning: [webkit-page] › page/page-leaks.spec.ts:107:5 › fill should not leak @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37181 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Nov 25 '24 13:11 github-actions[bot]

Test results for "tests 1"

22827 passed, 340 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 11 '24 15:12 github-actions[bot]

Test results for "tests 1"

15 failed :x: [chromium] › components/codeMirrorWrapper.spec.tsx:71:5 › highlight JavaScript @web-components-web :x: [chromium] › components/codeMirrorWrapper.spec.tsx:76:5 › highlight Python @web-components-web :x: [chromium] › components/codeMirrorWrapper.spec.tsx:81:5 › highlight Java @web-components-web :x: [chromium] › components/codeMirrorWrapper.spec.tsx:86:5 › highlight C# @web-components-web :x: [chromium] › components/codeMirrorWrapper.spec.tsx:91:5 › highlight lines @web-components-web :x: [chromium] › components/expandable.spec.tsx:22:5 › should render collapsed @web-components-web :x: [chromium] › components/expandable.spec.tsx:29:5 › should render expanded @web-components-web :x: [chromium] › components/expandable.spec.tsx:36:5 › click should expand @web-components-web :x: [chromium] › components/splitView.spec.tsx:22:5 › should render @web-components-web :x: [chromium] › components/splitView.spec.tsx:35:5 › should render sidebar first @web-components-web :x: [chromium] › components/splitView.spec.tsx:49:5 › should render horizontal split @web-components-web :x: [chromium] › components/splitView.spec.tsx:64:5 › should hide sidebar @web-components-web :x: [chromium] › components/splitView.spec.tsx:77:5 › drag resize @web-components-web :x: [chromium] › shared/imageDiffView.spec.tsx:37:5 › should render links @web-components-web :x: [chromium] › shared/imageDiffView.spec.tsx:46:5 › should show diff by default @web-components-web

0 passed :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 11 '24 15:12 github-actions[bot]

Test results for "tests 1"

1 flaky :warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37259 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 11 '24 16:12 github-actions[bot]

Test results for "tests 1"

1 failed :x: [playwright-test] › babel.spec.ts:135:5 › should not transform external @ubuntu-latest-node22-1

3 flaky :warning: [webkit-library] › library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
:warning: [webkit-library] › library/trace-viewer.spec.ts:1431:1 › should not record route actions @webkit-ubuntu-22.04-node18
:warning: [webkit-library] › library/trace-viewer.spec.ts:1512:1 › should serve css without content-type @webkit-ubuntu-22.04-node18

37281 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 13 '24 16:12 github-actions[bot]

Test results for "tests 1"

1 failed :x: [playwright-test] › playwright.artifacts.spec.ts:222:5 › should work with screenshot: only-on-failure & fullPage @macos-latest-node18-1

6 flaky :warning: [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:77:7 › should update aria snapshot highlight @firefox-ubuntu-22.04-node18
:warning: [firefox-page] › page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
:warning: [webkit-library] › library/debug-controller.spec.ts:202:1 › should record custom data-testid @webkit-ubuntu-22.04-node18
:warning: [webkit-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion @webkit-ubuntu-22.04-node18
:warning: [webkit-library] › library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
:warning: [webkit-page] › page/page-set-input-files.spec.ts:205:3 › should upload multiple large files @webkit-ubuntu-22.04-node18

37305 passed, 650 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Dec 16 '24 14:12 github-actions[bot]