playwright icon indicating copy to clipboard operation
playwright copied to clipboard

fix deprecation messages for `timeout` arguments that get ignored so that they show as deprecated in the typescript language server

Open DetachHead opened this issue 1 year ago • 2 comments

fixes #33017

DetachHead avatar Oct 15 '24 01:10 DetachHead

Test results for "tests 1"

2 fatal errors, not part of any test

2 flaky :warning: [webkit-library] › library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

35945 passed, 620 skipped, 1 did not run :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Oct 15 '24 03:10 github-actions[bot]

oh, that file is generated

DetachHead avatar Oct 15 '24 08:10 DetachHead

hey! are you planning to work on it? We try to keep the number of open PRs low - so if you don't, I'd close it for now so that it doesn't show up in our internal dashboards as untriaged.

mxschmitt avatar Oct 23 '24 10:10 mxschmitt

sorry i assumed leaving it as draft would be fine until i get around to looking at this again. will close it for now

DetachHead avatar Oct 23 '24 13:10 DetachHead