feat(ct): resolve hooksConfig import refs

[sand4rt]

trafficstars

closes https://github.com/microsoft/playwright/issues/30453 and https://github.com/microsoft/playwright/issues/19933

[github-actions[bot]]

Test results for "tests 1"

2 flaky

:warning: [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all
:warning: [webkit-library] › library/browsercontext-clearcookies.spec.ts:72:3 › should remove cookies by name regex

27406 passed, 672 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[github-actions[bot]]

Test results for "tests 1"

3 flaky

:warning: [firefox-library] › library/trace-viewer.spec.ts:1012:1 › should ignore 304 responses
:warning: [firefox-page] › page/page-click.spec.ts:848:3 › should not hang when frame is detached
:warning: [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path

27405 passed, 672 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[github-actions[bot]]

Test results for "tests 1"

3 flaky

:warning: [firefox-library] › library/trace-viewer.spec.ts:1012:1 › should ignore 304 responses
:warning: [firefox-page] › page/page-click.spec.ts:848:3 › should not hang when frame is detached
:warning: [webkit-library] › library/browsercontext-clearcookies.spec.ts:116:3 › should remove cookies by path

27405 passed, 672 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[github-actions[bot]]

Test results for "tests 1"

23390 passed, 495 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[github-actions[bot]]

Test results for "tests 1"

1 flaky

:warning: [webkit-page] › page/workers.spec.ts:243:3 › should support offline

27248 passed, 671 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[github-actions[bot]]

Test results for "tests 1"

1 flaky

:warning: [webkit-page] › page/page-goto.spec.ts:277:3 › should fail when navigating to bad SSL after redirects

27248 passed, 671 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

[pavelfeldman]

👋 @sand4rt 👋 taking care of our review debt. is this something you'd like me to look at?

[sand4rt]

👋 @pavelfeldman, yes please. Let me know if more info is needed

[pavelfeldman]

Tried reviewing it and failed - sounds like too many things are happening at a time. Any chance for it to be split in chunks? Also spotted a declare module there, we have general distaste to those, we like types to chain / infer explicitly instead.

[sand4rt]

Tried reviewing it and failed - sounds like too many things are happening at a time. Any chance for it to be split in chunks? Also spotted a declare module there, we have general distaste to those, we like types to chain / infer explicitly instead.

@pavelfeldman Sure, no problem. I split the first part in https://github.com/microsoft/playwright/pull/31024. Will do the second part later on because they depend on eachother.

I also usually distaste declare module too, but i think this is a really good use case for it, and they are entirely optional. Chain / infer explicitly is also still possible.