playwright icon indicating copy to clipboard operation
playwright copied to clipboard

feat(ct): class and object components

Open sand4rt opened this issue 1 year ago • 5 comments
trafficstars

closes https://github.com/microsoft/playwright/issues/29544, https://github.com/microsoft/playwright/issues/29928, partially https://github.com/microsoft/playwright/issues/31217 and introduces an improved approach for creating multiple wrapper/story components within a single file (considering it's only possible to define one component in a .vue file). @yjaaidi made the change in tsxTransform.ts

sand4rt avatar Apr 05 '24 17:04 sand4rt

Test results for "tests 1"

3 flaky :warning: [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
:warning: [firefox-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
:warning: [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26929 passed, 619 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Apr 05 '24 17:04 github-actions[bot]

Test results for "tests 1"

2 flaky :warning: [chromium-library] › library/capabilities.spec.ts:140:3 › should not crash on showDirectoryPicker
:warning: [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26930 passed, 619 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:

Merge workflow run.

github-actions[bot] avatar Apr 05 '24 19:04 github-actions[bot]

@pavelfeldman any chance this one could passthrough?

sand4rt avatar Apr 25 '24 19:04 sand4rt

👋 @sand4rt 👋 taking care of our review debt. is this something you'd like me to look at?

pavelfeldman avatar May 24 '24 19:05 pavelfeldman

👋 @pavelfeldman, yes please. Let me know if more info is needed.

I think @dgozman also has an opinion about this BTW. He mentioned something about this during the Angular PR review (a similar change is proposed there): https://github.com/microsoft/playwright/pull/27783#discussion_r1600463382

sand4rt avatar May 24 '24 21:05 sand4rt