playwright
playwright copied to clipboard
fix(playwright-ct-core): added missing exported test type
This PR fixes the misalignment between playwright-ct-core/index.js and playwright-ct-core/index.ts and ensures the latter export const test.
https://github.com/microsoft/playwright/blob/7f6f17d1c343f88400c498fd1c3defbd7f420056/packages/playwright-ct-core/index.js#L42
https://github.com/microsoft/playwright/blob/7f6f17d1c343f88400c498fd1c3defbd7f420056/packages/playwright-ct-core/index.d.ts#L48
Test results for "tests 1"
7 flaky
:warning: [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks:warning: [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
:warning: [firefox-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
:warning: [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
:warning: [chromium-page] › page/workers.spec.ts:199:3 › should report and intercept network from nested worker
:warning: [webkit-library] › library/browsercontext-remove-cookies.spec.ts:146:3 › should remove cookies by domain and path
:warning: [webkit-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
26931 passed, 631 skipped :heavy_check_mark::heavy_check_mark::heavy_check_mark:
Merge workflow run.
Would it be possible to start with filing a bug? Users are not intended to import '@playwright/experimental-ct-core'. Are you creating a custom component testing integration? This would help us a lot to understanding the change.
Hey @mxschmitt, we have a custom component testing integration for testing web components and noticed that the type defs in ct-core are not aligned with what's actually exported in index.js.
@mxschmitt I raised #29903
Closing as per discussion in the Issue.