playwright icon indicating copy to clipboard operation
playwright copied to clipboard

[Bug] keyboard/frame tests don't work with Electron 17+

Open mxschmitt opened this issue 3 years ago • 1 comments

Failing tests:

  15 failed
    [chromium] › page/page-click.spec.ts:32:1 › should click button inside frameset ================
    [chromium] › page/page-drag.spec.ts:205:3 › Drag and drop › should be able to drag the mouse in a frame 
    [chromium] › page/page-keyboard.spec.ts:88:1 › should report shiftKey ==========================
    [chromium] › page/page-keyboard.spec.ts:111:1 › should report multiple modifiers ===============
    [chromium] › page/page-keyboard.spec.ts:128:1 › should send proper codes while typing ==========
    [chromium] › page/page-keyboard.spec.ts:142:1 › should send proper codes while typing with shift 
    [chromium] › page/page-keyboard.spec.ts:172:1 › should press plus ==============================
    [chromium] › page/page-keyboard.spec.ts:181:1 › should press shift plus ========================
    [chromium] › page/page-keyboard.spec.ts:192:1 › should support plus-separated modifiers ========
    [chromium] › page/page-keyboard.spec.ts:203:1 › should support multiple plus-separated modifiers 
    [chromium] › page/page-keyboard.spec.ts:215:1 › should shift raw codes =========================
    [chromium] › page/page-keyboard.spec.ts:308:1 › should type emoji into an iframe ===============
    [chromium] › page/page-keyboard.spec.ts:382:1 › should work after a cross origin navigation ====
    [chromium] › page/page-set-input-files.spec.ts:248:1 › should not throw when filechooser belongs to iframe 
    [chromium] › page/page-set-input-files.spec.ts:269:1 › should not throw when frame is detached immediatel

CDP Input.dispatchKeyEvent, Input.dispatchMouseEvent regression:

  • Bisect range: https://github.com/electron/electron/compare/v18.0.0-nightly.20211123...v18.0.0-nightly.20211124
  • Bad: 18.0.0-nightly.20211124 bad
  • Good: 18.0.0-nightly.20211123: good
  • note: Input.writeText gets called, but it's a noop for some reason
  • Repro: https://gist.github.com/mxschmitt/8e85df87d970eb879dff58e8d5562cfd

mxschmitt avatar Jul 28 '22 15:07 mxschmitt

Relates https://github.com/microsoft/playwright/pull/16024

mxschmitt avatar Aug 01 '22 10:08 mxschmitt