playwright-java icon indicating copy to clipboard operation
playwright-java copied to clipboard

Playwright Java - is there a way to use system node version ?

Open mEklavya opened this issue 2 years ago • 4 comments

Playwright.create() is failing as it is installing the node.exe in the temp directory which the user is not allowed to run. Is there a way not to use this temp path and use system node js installed in program files

image

mEklavya avatar Jul 28 '22 22:07 mEklavya

No, the node.js and the driver files is essential part of Playwright. You can configure alternative location of the temp directory by providing playwright.driver.tmpdir java system property (see https://github.com/microsoft/playwright-java/issues/728 for more details). Would that work for you?

yury-s avatar Jul 28 '22 22:07 yury-s

Thanks, team for the quick response. No, it will not work. As in our organization, you can not run the .exe file until is whitelisted and digitally verified. Also, Node Js is available in Program files and the same needs to be used.

Is there any other way?

mEklavya avatar Jul 29 '22 10:07 mEklavya

We don't support running with a system node version as of today. There is a java property that is used for development purposes only, you can point that one to a preinstalled driver but you need to understand what you are doing as it has to be updated along with playwright etc. The property is playwright.cli.dir.

yury-s avatar Jul 29 '22 18:07 yury-s

What we can easily do is to allow providing a path to preinstalled Node.js in an environment variable or as Playwright constructor parameter. We'd still have to extract the node modules into a temp directory and run them from there. Would this approach address your issue or extracting even node js modules (all javascript, no native code as of today) to a temp directory would still be a problem?

yury-s avatar Aug 01 '22 17:08 yury-s

Thanks, it will be good to have environment variables for it, if the user doesn't pass then it takes default. Can the temp directory path be controlled using environment variables?

mEklavya avatar Aug 11 '22 21:08 mEklavya

Can the temp directory path be controlled using environment variables?

Only with a java system property today but we can add an environment variable too. Is there a reason why the java property doesn't work for you?

yury-s avatar Aug 11 '22 22:08 yury-s

Now that the PR has landed you can specify custom node location with PLAYWRIGHT_NODEJS_PATH env variable or playwright.nodejs.path java system property. You can give it a try in Playwright v1.26.0-SNAPSHOT

yury-s avatar Aug 16 '22 03:08 yury-s

Thank you @yury-s , will wait for updated version:)

One more query, in the current version, how can we know from where node and other dependencies are getting downloaded?

mEklavya avatar Aug 25 '22 06:08 mEklavya

The driver is extracted from driver-bundle maven package, on the first run it will download browsers from CDN.

yury-s avatar Aug 25 '22 20:08 yury-s

The driver is extracted from driver-bundle maven package, on the first run it will download browsers from CDN.

Thanks a lot, Yuri driver Bundle was clear, but what about other temp files in the Playwright-Java-xxxxxxx folder like Node.exe, playwright.cmd etc, from where it gets downloaded at the first run?

mEklavya avatar Aug 29 '22 07:08 mEklavya

Everything in the temp directory is extracted from the same module. Does it break somewhere in your environment?

yury-s avatar Aug 29 '22 18:08 yury-s

Everything in the temp directory is extracted from the same module. Does it break somewhere in your environment?

Yes, we see that printdeps.exe is not signed which is getting extracted from this module, and also not able to understand its usage. Can you please help us by signing it? As it is unsigned it is not allowed to run in corporate.

Also how often we will be updating our node.exe and other files which are getting downloaded in temp dir? Let's say if there is a version change in the node version then we will be adapting it.

mEklavya avatar Sep 02 '22 09:09 mEklavya

Yes, we see that printdeps.exe is not signed which is getting extracted from this module, and also not able to understand its usage. Can you please help us by signing it? As it is unsigned it is not allowed to run in corporate.

We can definitely sign it, it's an oversight on our end. The source code of the program is here, it hasn't changed for a while and the binary we use is here. We use it to check that all browser dependency libraries are present on the host system and if they are not we will print out missing ones.

Also how often we will be updating our node.exe and other files which are getting downloaded in temp dir? Let's say if there is a version change in the node version then we will be adapting it.

The node is baked into the driver-bundle package so it's only updated when that package is updated. If you install node separately it's up to you when to update it.

yury-s avatar Sep 02 '22 17:09 yury-s

Yes, we see that printdeps.exe is not signed which is getting extracted from this module, and also not able to understand its usage. Can you please help us by signing it? As it is unsigned it is not allowed to run in corporate.

We can definitely sign it, it's an oversight on our end. The source code of the program is here, it hasn't changed for a while and the binary we use is here. We use it to check that all browser dependency libraries are present on the host system and if they are not we will print out missing ones.

Thank you, will it be also available with the next version?

mEklavya avatar Sep 06 '22 14:09 mEklavya

@mEklavya can you help us to understand when the error comes up? Is there a repro or an error message? This would help us to prioritize.

mxschmitt avatar Sep 07 '22 16:09 mxschmitt

I filed an upstream feature request for it to sign the Windows binaries: https://github.com/microsoft/playwright/issues/17165

We unfortunately can't provide an eta for it, depending on the demand we'll work on it.

Since the original issue is fixed (make it possible to use a custom Node.js version) I'll close this one for now.

mxschmitt avatar Sep 07 '22 17:09 mxschmitt