playwright-dotnet icon indicating copy to clipboard operation
playwright-dotnet copied to clipboard

Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces

Open RaminJolfaei opened this issue 1 year ago • 3 comments

upgrade Microsoft.Bcl.AsyncInterfaces to latest version 8.0.0

RaminJolfaei avatar Sep 27 '24 09:09 RaminJolfaei

Is there a specific reason for this? In my opinion libraries should use the lowest version possible since the users can override them by explicitly include the references themselves. This was also done with System.Text.Json here https://github.com/microsoft/playwright-dotnet/pull/2720 Also since System.Text.Json references Microsoft.Bcl.AsyncInterfaces as well, these should be kept in sync.

campersau avatar Sep 27 '24 10:09 campersau

I think as long as our dependencies support netstandard we should be ok updating, see https://www.nuget.org/packages/Microsoft.Bcl.AsyncInterfaces/8.0.0#supportedframeworks-body-tab image

Meir017 avatar Sep 27 '24 12:09 Meir017

My primary reason for upgrading Microsoft.Bcl.AsyncInterfaces to version 8.0.0 is that our DevOps pipeline throws an error during the post-compile step. The pipeline checks DLL references and fails when it doesn’t find version 6 in the bin folder. To resolve this issue and ensure the pipeline can complete successfully, the upgrade to version 8 is necessary. I believe this change will not have any adverse side effects in other environments.

Additionally, most of the other packages we use are now dependent on version 8.0.0 of Microsoft.Bcl.AsyncInterfaces, making this upgrade essential for maintaining compatibility across the project.

RaminJolfaei avatar Sep 28 '24 04:09 RaminJolfaei

Closing as per above - please start with filing an issue with reproduction steps etc. Thank you!

mxschmitt avatar Nov 05 '24 15:11 mxschmitt