picologging icon indicating copy to clipboard operation
picologging copied to clipboard

Logger doesn't support weak reference

Open pamelafox opened this issue 2 years ago • 1 comments

CPython Logger supports weak reference, picologging Logger does not.

Supporting weakreference is fairly straightforward: https://docs.python.org/3.10/extending/newtypes.html#weak-reference-support

I tested that change locally and it works. I haven't been able to ascertain how much of a performance hit it is (if any), however. Let me know what you think and whether you'd like a PR.

pamelafox avatar Sep 24 '22 19:09 pamelafox