Various fixes in the generation of manifest files and C# code from them

[OfekShilon]

After running the manifest + C# generation on all ~1100 OS-registered providers, it seems ~20% fail to generate manifests, and of those that succeed ~30% fail to generate valid C# code. This is a start of an attempt to improve the state of these (mighty useful!) features. All solving real generation problems. Will add xUnit tests in a future PR.

[codecov-io]

Codecov Report

Merging #835 into master will increase coverage by 0.06%. The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   17.33%    17.4%   +0.06%     
==========================================
  Files         222      222              
  Lines      137798   137803       +5     
  Branches    12199    12199              
==========================================
+ Hits        23893    23989      +96     
  Misses     112876   112876              
+ Partials     1029      938      -91

Flag	Coverage Δ
#2017	17.4% <62.5%> (+0.06%)	:arrow_up:
#Debug	17.4% <62.5%> (+0.06%)	:arrow_up:
#Release	100% <ø> (ø)	:arrow_up:

Impacted Files	Coverage Δ
src/TraceEvent/RegisteredTraceEventParser.cs	46.77% <62.5%> (+0.31%)	:arrow_up:
src/PerfView/StackViewer/StackWindow.xaml.cs	24.83% <0%> (-0.13%)	:arrow_down:
src/PerfView/StackViewer/PerfDataGrid.xaml.cs	33.92% <0%> (ø)	:arrow_up:
...c/TraceEvent/Parsers/ClrPrivateTraceEventParser.cs	19.12% <0%> (+0.03%)	:arrow_up:
src/TraceEvent/TraceLog.cs	60.26% <0%> (+0.08%)	:arrow_up:
src/TraceEvent/DynamicTraceEventParser.cs	66.34% <0%> (+0.12%)	:arrow_up:
src/TraceEvent/TraceEvent.cs	63.05% <0%> (+0.13%)	:arrow_up:
src/TraceEvent/ETWTraceEventSource.cs	46.05% <0%> (+0.19%)	:arrow_up:
src/TraceEvent/Parsers/TplTraceEventParser.cs	48.94% <0%> (+0.21%)	:arrow_up:
src/TraceEvent/Stacks/FilterStacks.cs	48.9% <0%> (+0.27%)	:arrow_up:
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52c80f7...d77130b. Read the comment docs.

[OfekShilon]

Is it possible to add a PR with new tests that do not pass? (I think it is a per-repository policy in github)

[brianrob]

@OfekShilon thank you for the contribution and apologies for the delay in responding to this. Can you please rebase your PR and then see which of your changes are still needed? #950 also includes changes in this space and it looks like some of them overlap. Thanks!