Remove histogram from memory stacks
The histogram in this view showed the location of managed objects in memory. I didn't find it particularly useful, but calculating it resulted in substantial performance overhead when trying to review the results from large heap dumps.
:memo: Please make sure to not rebase or squash this change during the merge process.
Codecov Report
Merging #431 into master will increase coverage by
0.12%. The diff coverage is100%.
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 17.44% 17.56% +0.12%
==========================================
Files 213 213
Lines 123790 123790
Branches 11971 11971
==========================================
+ Hits 21590 21745 +155
+ Misses 101189 101186 -3
+ Partials 1011 859 -152
| Flag | Coverage Δ | |
|---|---|---|
| #2017 | 17.56% <100%> (+0.12%) |
:arrow_up: |
| #Debug | 17.56% <100%> (+0.12%) |
:arrow_up: |
| #Release | 100% <ø> (ø) |
:arrow_up: |
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/PerfView/StackViewer/StackWindow.xaml.cs | 25.85% <100%> (ø) |
:arrow_up: |
| src/PerfView/StackViewer/PerfDataGrid.xaml.cs | 34.02% <0%> (ø) |
:arrow_up: |
| ...c/TraceEvent/Parsers/ClrPrivateTraceEventParser.cs | 19.58% <0%> (+0.03%) |
:arrow_up: |
| src/TraceEvent/TraceEvent.cs | 63.34% <0%> (+0.1%) |
:arrow_up: |
| src/TraceEvent/DynamicTraceEventParser.cs | 67.49% <0%> (+0.15%) |
:arrow_up: |
| src/TraceEvent/TraceLog.cs | 61.25% <0%> (+0.2%) |
:arrow_up: |
| src/TraceEvent/Parsers/TplTraceEventParser.cs | 49.65% <0%> (+0.22%) |
:arrow_up: |
| src/TraceEvent/ETWTraceEventSource.cs | 47.34% <0%> (+0.23%) |
:arrow_up: |
| src/PerfView/StackViewer/CallTreeView.cs | 47.94% <0%> (+0.25%) |
:arrow_up: |
| src/TraceEvent/Stacks/FilterStacks.cs | 50.71% <0%> (+0.31%) |
:arrow_up: |
| ... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update ed9cc8d...97ee9ef. Read the comment docs.
Updated after repository rewrite
Great idea.