perfview icon indicating copy to clipboard operation
perfview copied to clipboard

Namespace cleanup

Open sharwell opened this issue 7 years ago • 4 comments

  • Move command classes from global::Utilities to global::Microsoft.Diagnostics.Tracing.Utilities
  • Move PE file classes from global::PEFile to global::Microsoft.Diagnostics.Tracing.PEFile

sharwell avatar Jun 04 '17 07:06 sharwell

Codecov Report

Merging #266 into master will increase coverage by 0.2%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #266     +/-   ##
=========================================
+ Coverage   24.32%   24.52%   +0.2%     
=========================================
  Files         197      197             
  Lines      112379   113324    +945     
  Branches    11208    11502    +294     
=========================================
+ Hits        27331    27795    +464     
- Misses      85021    85486    +465     
- Partials       27       43     +16
Flag Coverage Δ
#2015 24.3% <0%> (-0.02%) :arrow_down:
#2017 24.35% <0%> (+0.03%) :arrow_up:
#Debug 16.09% <0%> (+0.31%) :arrow_up:
#Release 14.9% <0%> (+0.04%) :arrow_up:
Impacted Files Coverage Δ
src/TraceEvent/TraceLog.cs 64.18% <ø> (-2.42%) :arrow_down:
src/PerfView/CommandProcessor.cs 16.07% <ø> (ø) :arrow_up:
src/TraceEvent/Utilities/command.cs 13.31% <ø> (ø) :arrow_up:
src/PerfView/StackViewer/StackWindow.xaml.cs 34.39% <ø> (-0.04%) :arrow_down:
src/TraceEvent/Parsers/KernelTraceEventParser.cs 41.28% <ø> (ø) :arrow_up:
src/TraceEvent/ETWTraceEventSource.cs 57.96% <ø> (ø) :arrow_up:
src/TraceEvent/TraceUtilities/PEFile.cs 16.84% <ø> (ø) :arrow_up:
src/PerfView/MainWindow.xaml.cs 28.86% <ø> (ø) :arrow_up:
src/TraceEvent/Stacks/AggregateStackSource.cs 7.73% <ø> (ø) :arrow_up:
src/PerfView/PerfViewData.cs 17.43% <ø> (ø) :arrow_up:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da21a66...fc2b5ff. Read the comment docs.

codecov-io avatar Jun 04 '17 09:06 codecov-io

This is tied up with the issue whether these classes are exposed in TraceEvent.

Currently they are NOT, as they are not really logically related to logging, and I think that is probably for the best.

vancem avatar Jun 05 '17 01:06 vancem

@vancem Currently these files are exposed by the TraceEvent library (including the NuGet package build of this library), and PerfView consumes them from there. Since it appeared to be a true single point of definition in what is intended to be a reusable library, it seemed to make sense to place them in a namespace used by the rest of the same library.

sharwell avatar Jun 05 '17 14:06 sharwell

Updated after repository rewrite

sharwell avatar Feb 02 '18 12:02 sharwell