perfview icon indicating copy to clipboard operation
perfview copied to clipboard

Add AutomationProperties.Name to Process Selection DataGrid for accessibility

Open Copilot opened this issue 6 months ago • 1 comments

Fixes an accessibility issue where the DataGrid in the "Select Process Window" popup lacked a proper name for screen readers and assistive technologies.

Problem

When using accessibility tools like "Accessibility Insights for Windows" on the Select Process dialog, the DataGrid element showed as datagrid '' with an empty name, violating the accessibility requirement that "The Name property of a focusable element must not be null."

Solution

Added AutomationProperties.Name="Process selection table" to the DataGrid element in SelectProcess.xaml. This provides a meaningful, descriptive name for screen readers and follows the established pattern used throughout the PerfView codebase for similar controls.

Changes

  • Minimal change: Added one line to /src/PerfView/Dialogs/SelectProcess.xaml
  • Consistent naming: Follows existing patterns like "Events Table", "Multi-Line View", etc.
  • No functional impact: Only improves accessibility, no behavior changes

Testing

  • Verified XAML is well-formed
  • Confirmed change follows established codebase patterns
  • Minimal scope: only 1 file modified with 1 line addition

Fixes #2238.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot avatar Jun 13 '25 18:06 Copilot

Co-pilot Post-Mortem:

  • The code was easy for copilot to get right.
  • I appreciated that the PR description described the solution and called out that this was done elsewhere for comparison, such that I was able to build reasonable confidence in the fix rather quickly.

brianrob avatar Jun 13 '25 21:06 brianrob