perfview icon indicating copy to clipboard operation
perfview copied to clipboard

Fix TraceParserGen to generate meaningful parser for WPF

Open oatkins opened this issue 3 years ago • 2 comments

This attempts to resolve https://github.com/microsoft/perfview/issues/1351 and supports creating a parser for the Microsoft-Windows-WPF provider from the manifest at C:\Windows\Microsoft.NET\Framework\v4.0.30319\WPF\wpf-etw.man.

See also https://github.com/microsoft/perfview/issues/554.

Addresses various issues with the generated provider:

  • Enum should not be normalized it if's already PascalCase, so the normalizing logic is skipped if no "_" is present in a field name.
  • RegisterTemplate() seems not to exist; source.RegisterEventTemplate is apparently what was intended.
  • Task GUID constants were previously referenced but not generated.
  • Template class names were incorrectly referenced.

oatkins avatar Apr 06 '21 21:04 oatkins

CLA assistant check
All CLA requirements met.

ghost avatar Apr 06 '21 21:04 ghost

See also #950 - need to make sure the problems resolved there are not reintroduced here.

oatkins avatar Apr 08 '21 13:04 oatkins