perfview icon indicating copy to clipboard operation
perfview copied to clipboard

TraceParserGen: xxxTaskGuid not defined

Open dorian-apanel-intel opened this issue 4 years ago • 4 comments

I'm trying to compile cs code generated by TraceParserGen with custom manifest.

First problem I see is that guids passed to RegisterTemplate() are not defied. Then I found this comment in code

// as of today, the generated code won't compile because the task GUID is not defined
// TODO: define the xxxTaskGuid based on eventGUID attribute of <task> elements of the .man file

Is it going to be fixed? It happens both if I define eventGUID attribute or not.

dorian-apanel-intel avatar Jan 27 '21 14:01 dorian-apanel-intel

@dorian-apanel-intel, this can be fixed, but wasn't an issue that I was aware of. Would you be up for submitting a PR for this?

brianrob avatar Feb 01 '21 18:02 brianrob

Hi, I fixed it for myself. I'm going to propose a PR soon.

dorian-apanel-intel avatar Feb 02 '21 15:02 dorian-apanel-intel

Is this fixed?

limulidae avatar Oct 18 '23 03:10 limulidae

I don't believe that this has been fixed. Fixes to TraceParserGen have been held up behind a goal to create a test-bed for the tool first, as each time we take a change, we tend to break something.

brianrob avatar Oct 30 '23 17:10 brianrob