perfview icon indicating copy to clipboard operation
perfview copied to clipboard

Suspicious code in ConvertMarkTimes

Open ghost opened this issue 6 years ago • 1 comments

ConvertMarkTimes() in TraceManagedProcess.cs contains the following code:

if (item.Value.MarkTimes[(int)MarkRootType.MarkOlder] == 0.0)
{
    item.Value.MarkTimes[(int)MarkRootType.MarkOverflow] -= item.Value.MarkTimes[(int)MarkRootType.MarkOlder];
}

If item.Value.MarkTimes[(int)MarkRootType.MarkOlder] == 0.0, then subtracting it should have no effect.

ghost avatar Dec 06 '19 18:12 ghost

Due to lack of recent activity, this issue has been labeled as 'stale'. It will be closed if no further activity occurs within 30 more days. Any new comment will remove the label.

github-actions[bot] avatar Dec 07 '25 03:12 github-actions[bot]