openvmm icon indicating copy to clipboard operation
openvmm copied to clipboard

TODO TDX comments were removed

Open ckotamra opened this issue 1 year ago • 5 comments

TODO TDX comments were removed and corresponding issue items have been created. Closes #523

ckotamra avatar Dec 18 '24 23:12 ckotamra

Hi - Could you elaborate? Do you mean that these TODOs are all fully resolved, or just that there are now issues tracking each of the TODOs?

mattkur avatar Dec 19 '24 00:12 mattkur

There are issue items created to track all these TODO TDX changes. Some of them have already been resolved.

ckotamra avatar Dec 19 '24 00:12 ckotamra

@ckotamra all issues originally identified by you are in this repo (I went through them this AM), to expand, rather than delete each TODO comment, please change each TODO comment to either A) resolved is {link to closed issue} or B) TODO originally identified here but now tracked in {link to open issue}

cperezvargas avatar Dec 20 '24 17:12 cperezvargas

Personally I still lean towards keeping the TODOs in the code, even if issues have been made for them, until the issue is resolved.

smalis-msft avatar Jan 17 '25 15:01 smalis-msft

@ckotamra - looks like this PR is stale. Are you planning on rebasing this?

benhillis avatar Apr 21 '25 18:04 benhillis