vm_info on Windows x64 (perhaps other platforms as well) not stating who built the VM

[karianna]

VM Crash reports have this in their logs:

vm_info: OpenJDK 64-Bit Server VM (16.0.1+9) for windows-amd64 JRE (16.0.1+9), built on Apr 21 2021 17:16:40 by "" with MS VC++ 16.8 (VS2019)

Should probably say this

vm_info: OpenJDK 64-Bit Server VM (16.0.1+9) for windows-amd64 JRE (16.0.1+9), built on Apr 21 2021 17:16:40 by **"Microsoft Corporation Ltd."** with MS VC++ 16.8 (VS2019) or something close to that

[brunoborges]

@d3r3kk is the vm_info adjusted as expected here now?

[d3r3kk]

Seems to only be present for Windows builds? See here for where it gets injected into the report and here for where it gets set (I cannot seem to find anywhere else it is being set at the moment).

The value is used in a few places though so we probably should set it.

[d3r3kk]

Looks like could accomplish this by adding more to the configure parameter set, specifically --with-extra-cxxflags=DHOTSPOT_BUILD_USER="Microsoft Corporation Ltd."

[brunoborges]

@d3r3kk was that flag added for the April builds?