microsoft
Cjian/dml ng
Are all GPU CIs will be merged into one in future?
Specifically, I would like to know whether WebGPU CIs should be put into this CI or saperatedly.
I would like to know whether WebGPU CIs should be put into this CI or saperatedly.
If you are talking about pull request pipelines, please put it separately. Jian's this PR is for adding DML EP to our existing GPU packages. See the ADO link in the PR's description for more information.
DML EP depends on
- DirectML.dll
- dxgi.dll
- DXCore.dll
- D3D12.dll
They are usually part of Windows . We also distribute DirectML.dll in our python package.
DML EP depends on
- DirectML.dll
- dxgi.dll
- DXCore.dll
- D3D12.dll
They are usually part of Windows . We also distribute DirectML.dll in our python package.
Let's say we ship this package. Will a user who doesn't want to use DML EP for inferencing need to install DML related deps? If you remember this was the very reason, we'd to separate CUDA EP into a separate DLL so that the core DLL doesn't have to depend on the CUDA EP deps. Are you suggesting that since the DML EP deps are present on all Windows machines, we don't need to worry separating DML EP into a separate DLL?
Will a user who doesn't want to use DML EP for inferencing need to install DML related deps?
No, they do not. All Windows 10 and Windows 11 should already have DX12. We can ask the Windows team to get confirmed.
Are you suggesting that since the DML EP deps are present on all Windows machines, we don't need to worry separating DML EP into a separate DLL?
No, I am not suggesting that. Being modular always has benefits. If onnxruntime.dll doesn't have EP specific code, then we can build DML EP and CUDA EP separately on different hosts in parallel, then extract the EP DLLs out and put them together in a single package. It would be trivial and simple.
I think this would fulfill my feature request: https://github.com/microsoft/onnxruntime/issues/21615
Close this PR. The feature has been implmented by https://github.com/microsoft/onnxruntime/pull/22602