onnxruntime icon indicating copy to clipboard operation
onnxruntime copied to clipboard

Refactor CoreMLExecution to C++ bridge class

Open 1enn0 opened this issue 1 year ago • 1 comments

Description

Refactor Objective-C++ class CoreMLExecution into existing C++ bridge class onnxruntime::coreml::Execution.

Motivation and Context

Fixes #21708.

1enn0 avatar Aug 26 '24 10:08 1enn0

@microsoft-github-policy-service agree company="Steinberg Media Technologies GmbH"

1enn0 avatar Sep 03 '24 11:09 1enn0

@edgchen1 thanks for your thorough review. I have to admit the previous state was a bit half-baked on my part. Hopefully I did not miss anything this time.

I also ran clang-format on this file which makes it a bit harder to review my changes now (looks like this has not been done for a while).

1enn0 avatar Sep 04 '24 13:09 1enn0

I also ran clang-format on this file which makes it a bit harder to review my changes now (looks like this has not been done for a while).

Thanks for considering the formatting. Actually, we do have a CI check that ensures that (most of) our code is formatted, including this file. This repo has its own .clang-format files, like this one.

In particular, we have a convention of a 120 character line length limit and the formatting changes in this PR seem to assume a lower limit. If possible, would you mind reverting the formatting changes and re-running clang-format with the .clang-format files in this repo? It should be the default behavior of clang-format if no formatting configuration options are given.

edgchen1 avatar Sep 04 '24 19:09 edgchen1

If possible, would you mind reverting the formatting changes and re-running clang-format with the .clang-format files in this repo?

Should be fine now...

1enn0 avatar Sep 05 '24 11:09 1enn0

/azp run iOS CI Pipeline

edgchen1 avatar Sep 05 '24 16:09 edgchen1

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 05 '24 16:09 azure-pipelines[bot]

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

edgchen1 avatar Sep 11 '24 00:09 edgchen1

/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline

edgchen1 avatar Sep 11 '24 00:09 edgchen1

/azp run Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

edgchen1 avatar Sep 11 '24 00:09 edgchen1

Azure Pipelines successfully started running 5 pipeline(s).

azure-pipelines[bot] avatar Sep 11 '24 00:09 azure-pipelines[bot]

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines[bot] avatar Sep 11 '24 00:09 azure-pipelines[bot]

Azure Pipelines successfully started running 10 pipeline(s).

azure-pipelines[bot] avatar Sep 11 '24 00:09 azure-pipelines[bot]

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline

edgchen1 avatar Sep 11 '24 19:09 edgchen1

/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline

edgchen1 avatar Sep 11 '24 19:09 edgchen1

/azp run Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

edgchen1 avatar Sep 11 '24 19:09 edgchen1

Azure Pipelines successfully started running 5 pipeline(s).

azure-pipelines[bot] avatar Sep 11 '24 19:09 azure-pipelines[bot]

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines[bot] avatar Sep 11 '24 19:09 azure-pipelines[bot]

Azure Pipelines successfully started running 10 pipeline(s).

azure-pipelines[bot] avatar Sep 11 '24 19:09 azure-pipelines[bot]