onnxruntime icon indicating copy to clipboard operation
onnxruntime copied to clipboard

Use the scalar MlasSgemm CopyPackB and TransposePackB implementation for RISCV

Open KaustubhIMG opened this issue 1 year ago • 6 comments

Add new define MLAS_TARGET_RISCV under _M_RISCV or __riscv. Add MLAS_TARGET_RISCV in check across MlasSgemmCopyPackB and MlasSgemmTransposePackB implementation to use 4 wide packing functions.

For RISCV, the MlasSgemmKernel is used which has packing wide of 4. The default MlasSgemmCopyPackB (which was under just !defined(MLAS_TARGET_WASM_SCALAR) chack) has packing width of 16, causing the tests to mismatch.

KaustubhIMG avatar Jul 05 '24 12:07 KaustubhIMG

@microsoft-github-policy-service agree [company="{Imagination Technologies}"]

KaustubhIMG avatar Jul 30 '24 04:07 KaustubhIMG

@microsoft-github-policy-service agree company="Imagination Technologies"

KaustubhIMG avatar Jul 30 '24 04:07 KaustubhIMG

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

yufenglee avatar Jul 30 '24 18:07 yufenglee

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

yufenglee avatar Jul 30 '24 18:07 yufenglee

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

yufenglee avatar Jul 30 '24 18:07 yufenglee

@yufenglee Can you review the changes?

KaustubhIMG avatar Aug 20 '24 08:08 KaustubhIMG

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

yufenglee avatar Sep 16 '24 21:09 yufenglee

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline

yufenglee avatar Sep 16 '24 21:09 yufenglee

/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

yufenglee avatar Sep 16 '24 21:09 yufenglee

Stale.

snnn avatar Jul 03 '25 18:07 snnn