onnxruntime
onnxruntime copied to clipboard
microsoft
turn on neural_speed by default
Description
the crash caused by the neural_speed turns out to be a very corn case. Turn it on by default.
Motivation and Context
In my opinion the problem still should be fixed, especially we see the fix is there but for what reason we refuse doing so? Windows and Office are deployed to billions of devices. So definitely some people will hit the issue. Even if they only represent a small percentage of the total population, we will still see a huge number of crash reports. Besides, xbyak is also a new dependency which may also have compatibility issues. This is the first time we introduce a JIT engine in the core framework and the code will be deployed billions of devices. Should we be more careful on that? Anyone peeked into xbyak's code? xbyak does a lot of non-trivial things. I would think this is the biggest change we ever had in ONNX Runtime in the past 6 years.
In my opinion the problem still should be fixed, especially we see the fix is there but for what reason we refuse doing so? Windows and Office are deployed to billions of devices. So definitely some people will hit the issue. Even if they only represent a small percentage of the total population, we will still see a huge number of crash reports. Besides, xbyak is also a new dependency which may also have compatibility issues. This is the first time we introduce a JIT engine in the core framework and the code will be deployed billions of devices. Should we be more careful on that? Anyone peeked into xbyak's code? xbyak does a lot of non-trivial things. I would think this is the biggest change we ever had in ONNX Runtime in the past 6 years.
the fix is in progress. At the same time, we don't want user to experience very slow experience for the corner case.