onnxruntime icon indicating copy to clipboard operation
onnxruntime copied to clipboard

Clean up build.py

Open jchen351 opened this issue 1 year ago • 4 comments

Description

Clean up build.py

Motivation and Context

Moving nonessential functions to the onnxruntime/tools/python/util package. Only left function that are meaningful to the build process.

jchen351 avatar Jan 16 '24 05:01 jchen351

An import error seen: https://github.com/microsoft/onnxruntime/actions/runs/7547312086/job/20546973767?pr=19156#step:5:12

justinchuby avatar Jan 16 '24 20:01 justinchuby

Moving nonessential functions to the onnxruntime/tools/python/util package. Only left function that are meaningful to the build process.

Can you clarify what "nonessential" means? I gather it's different from "unused", but it seems that anything that is used is "essential" in some way. I ask so that when we add new functions in the future we know where to put them.

edgchen1 avatar Jan 18 '24 17:01 edgchen1

Moving nonessential functions to the onnxruntime/tools/python/util package. Only left function that are meaningful to the build process.

Can you clarify what "nonessential" means? I gather it's different from "unused", but it seems that anything that is used is "essential" in some way. I ask so that when we add new functions in the future we know where to put them.

We can put all future helper functions into the files from tools/python/util/ folder. The build.py has been growing too large to navigate IMO.

jchen351 avatar Jan 18 '24 21:01 jchen351

@jchen351, Is it still needed? If not, please close it.

tianleiwu avatar Apr 05 '24 13:04 tianleiwu