onnxruntime icon indicating copy to clipboard operation
onnxruntime copied to clipboard

Adds a react-native test using the android API

Open Craigacp opened this issue 3 years ago • 16 comments

Description:

Adds a test which should trigger #11451 on Android. It also adds the same tests to Java, but those already passed.

I suspect the react tests could be cleaned up more, but I've no idea how they are actually run, or if there can be multiple modules, so someone who better understands how those tests are run should take a look. I don't have an environment setup to allow me to run them locally, though I have checked the new Java side tests.

cc @fs-eire

Motivation and Context

  • Why is this change required? What problem does it solve? Test for the JNI refactor when using Android & react-native.
  • If it fixes an open issue, please link to the issue here.

Craigacp avatar Aug 19 '22 19:08 Craigacp

/azp run ONNX Runtime React Native CI Pipeline

fs-eire avatar Aug 19 '22 20:08 fs-eire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 19 '22 20:08 azure-pipelines[bot]

/azp run ONNX Runtime React Native CI Pipeline

fs-eire avatar Aug 23 '22 05:08 fs-eire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 23 '22 05:08 azure-pipelines[bot]

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

fs-eire avatar Aug 25 '22 00:08 fs-eire

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline

fs-eire avatar Aug 25 '22 00:08 fs-eire

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines[bot] avatar Aug 25 '22 00:08 azure-pipelines[bot]

Azure Pipelines successfully started running 8 pipeline(s).

azure-pipelines[bot] avatar Aug 25 '22 00:08 azure-pipelines[bot]

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

fs-eire avatar Aug 31 '22 00:08 fs-eire

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline

fs-eire avatar Aug 31 '22 00:08 fs-eire

Azure Pipelines successfully started running 8 pipeline(s).

azure-pipelines[bot] avatar Aug 31 '22 00:08 azure-pipelines[bot]

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines[bot] avatar Aug 31 '22 00:08 azure-pipelines[bot]

Looks like the training pipeline failure was due to a CI VM error, could someone re-run it?

Craigacp avatar Sep 07 '22 17:09 Craigacp

@fs-eire please could you kick off the orttraining-linux-ci-pipeline? The failure is unrelated to this PR, it looks like the VM filled its disk up. The JNI changes have all been merged in, so this test is the last part of that work.

Craigacp avatar Sep 15 '22 21:09 Craigacp

/azp run orttraining-linux-ci-pipeline

fs-eire avatar Sep 19 '22 23:09 fs-eire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 19 '22 23:09 azure-pipelines[bot]

I think I made all the requested changes here. Can @yuslepukin or @fs-eire review it again?

Craigacp avatar Nov 07 '22 20:11 Craigacp

Is this change still applicable and should be checked-in?

YUNQIUGUO avatar Oct 11 '23 22:10 YUNQIUGUO

Yes, though it may need rebasing to make it merge cleanly. The tests always passed on Java, this adds tests which did fail on android before the JNI refactor last year and now should not.

Craigacp avatar Oct 11 '23 23:10 Craigacp

/azp run ONNX Runtime React Native CI Pipeline

fs-eire avatar Oct 12 '23 00:10 fs-eire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 12 '23 00:10 azure-pipelines[bot]

Looks like the react code changed a little around me, so I'll rebase this branch on main and then try to figure out what the test should look like.

Craigacp avatar Oct 12 '23 17:10 Craigacp

I've updated the react test, hopefully that should pass the CI now.

Craigacp avatar Oct 13 '23 00:10 Craigacp

/azp run ONNX Runtime React Native CI Pipeline

yuslepukhin avatar Oct 13 '23 20:10 yuslepukhin

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 13 '23 20:10 azure-pipelines[bot]

/azp run ONNX Runtime React Native CI Pipeline

fs-eire avatar Oct 15 '23 07:10 fs-eire

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 15 '23 07:10 azure-pipelines[bot]

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

fs-eire avatar Oct 16 '23 16:10 fs-eire

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-python-checks-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline

fs-eire avatar Oct 16 '23 16:10 fs-eire

Azure Pipelines successfully started running 8 pipeline(s).

azure-pipelines[bot] avatar Oct 16 '23 16:10 azure-pipelines[bot]