onnxruntime icon indicating copy to clipboard operation
onnxruntime copied to clipboard

Remove temp downloading NDK 25

Open mszhanyi opened this issue 3 years ago • 1 comments

Description: Remove the hot fix (downing NDK25) introduced in #12350

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

mszhanyi avatar Aug 08 '22 07:08 mszhanyi

Please keep the pinning of the specific NDK version. You can remove the installation if you want. It's hard to detect if NDK version changes introduce issues otherwise.

edgchen1 avatar Aug 08 '22 16:08 edgchen1

I'm trying to update the VM images. I will still need a few days.

snnn avatar Aug 12 '22 18:08 snnn

Please keep the pinning of the specific NDK version. You can remove the installation if you want. It's hard to detect if NDK version changes introduce issues otherwise.

It might be necessary only for jobs on Mac whose image are not controlled by us.

mszhanyi avatar Aug 15 '22 08:08 mszhanyi

Please keep the pinning of the specific NDK version. You can remove the installation if you want. It's hard to detect if NDK version changes introduce issues otherwise.

It might be necessary only for jobs on Mac whose image are not controlled by us.

I think we need to use a consistent version across different jobs. Explicitly specifying it (in this codebase) is helpful in my opinion, even if it's not necessary. I did spend a significant amount of time investigating an issue related to an NDK version change recently.

edgchen1 avatar Aug 16 '22 16:08 edgchen1