onnxruntime icon indicating copy to clipboard operation
onnxruntime copied to clipboard

MIGraphx as an Engine

Open smicic-htec opened this issue 3 years ago • 16 comments

Description: Adding MIGraphx as an engine

Motivation and Context

  • Additional option when comparing performances between runs.
  • Comparing migraphx as an engine vs as an execution provider (ONNX)

smicic-htec avatar Jun 24 '22 12:06 smicic-htec

CLA assistant check
All CLA requirements met.

ghost avatar Jun 24 '22 12:06 ghost

This pull request introduces 1 alert when merging 195024abdbc0d6e8bd70b5512b7e482776535b49 into 0d6cbc6e57c2ecd0722cefaa87d300f301864e3b - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Jun 24 '22 13:06 lgtm-com[bot]

What does it take for these other pipelines to run?

mvermeulen avatar Jul 06 '22 13:07 mvermeulen

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, MacOS NoContribops CI Pipeline, Windows CPU CI Pipeline

weixingzhang avatar Jul 06 '22 17:07 weixingzhang

/azp run Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, centos7_cpu, centos7_cpu (linux_centos_ci Debug), centos7_cpu (linux_centos_ci Release), orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-amd-gpu-ci-pipeline, Linux Nuphar CI Pipeline, orttraining-distributed

weixingzhang avatar Jul 06 '22 17:07 weixingzhang

/azp run orttraining-ortmodule, orttraining-ortmodule-distributed, ONNX Runtime Web CI Pipeline, onnxruntime-python-checks-ci-pipeline

weixingzhang avatar Jul 06 '22 17:07 weixingzhang

Azure Pipelines successfully started running 7 pipeline(s).

azure-pipelines[bot] avatar Jul 06 '22 17:07 azure-pipelines[bot]

Azure Pipelines successfully started running 6 pipeline(s).

azure-pipelines[bot] avatar Jul 06 '22 17:07 azure-pipelines[bot]

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines[bot] avatar Jul 06 '22 17:07 azure-pipelines[bot]

Failures has nothing to do with my changes. All of the lines already exist in other functions within the same file.

smicic-htec avatar Jul 13 '22 15:07 smicic-htec

Failures has nothing to do with my changes. All of the lines already exist in other functions within the same file.

I did a check, it looks like the last time the file was touched was in April. It also appears that the Linting tools for the CI were added after April. Can you please fix the lint issues too

causten avatar Jul 14 '22 15:07 causten

This pull request introduces 1 alert when merging d3f10bbf6aba0cb6aed30ad52a98daeb0fd8ac59 into 52095fb042ebcb9f1e520d58b23fb9cec260aab3 - view on LGTM.com

new alerts:

  • 1 for Returning tuples with varying lengths

lgtm-com[bot] avatar Jul 18 '22 08:07 lgtm-com[bot]

This pull request introduces 1 alert when merging 772cc3b807b425f97ecaf15538df58fb081efd51 into 52095fb042ebcb9f1e520d58b23fb9cec260aab3 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

lgtm-com[bot] avatar Jul 18 '22 08:07 lgtm-com[bot]

This pull request fixes 1 alert when merging 813f47bd6a75f58269ec6e6a0018b73ffee56367 into bb5bd08545b6b12f61851692f762ec46bbaa5980 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Jul 19 '22 08:07 lgtm-com[bot]

@causten can you ping someone to run other checks?

smicic-htec avatar Jul 20 '22 08:07 smicic-htec

@weixingzhang issues have been addressed, can we run the workflows again. Thank you.

mvermeulen avatar Jul 20 '22 13:07 mvermeulen