onnxruntime icon indicating copy to clipboard operation
onnxruntime copied to clipboard

make nhwc transformer only apply to CPU ep.

Open Jamather opened this issue 2 years ago • 25 comments

Description: Also clean up nchwc transformer to be more consistent with other transformers (taking an argument of supported EPs instead of hardcoding the behavior)

Motivation and Context

  • QLinearConv does not work with DML EP because this optimizer intended for CPU EP is wrongfully applied to it.

Jamather avatar Jun 17 '22 00:06 Jamather

Adding Scott as Tom is on a different team now.

fdwr avatar Jun 17 '22 01:06 fdwr

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux Nuphar CI Pipeline,Linux OpenVINO CI Pipeline,MacOS CI Pipeline,ONNX Runtime Web CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,onnxruntime-python-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

fdwr avatar Jun 17 '22 20:06 fdwr

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

azure-pipelines[bot] avatar Jun 17 '22 20:06 azure-pipelines[bot]

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline

fdwr avatar Jun 17 '22 20:06 fdwr

Azure Pipelines successfully started running 10 pipeline(s).

azure-pipelines[bot] avatar Jun 17 '22 20:06 azure-pipelines[bot]

/azp run Windows GPU TensorRT CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline,o nnxruntime-python-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

fdwr avatar Jun 17 '22 20:06 fdwr

Azure Pipelines successfully started running 5 pipeline(s).

azure-pipelines[bot] avatar Jun 17 '22 20:06 azure-pipelines[bot]

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline

fdwr avatar Jun 19 '22 00:06 fdwr

/azp run Windows GPU TensorRT CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline,o nnxruntime-python-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

fdwr avatar Jun 19 '22 00:06 fdwr

Azure Pipelines successfully started running 5 pipeline(s).

azure-pipelines[bot] avatar Jun 19 '22 00:06 azure-pipelines[bot]

Azure Pipelines successfully started running 10 pipeline(s).

azure-pipelines[bot] avatar Jun 19 '22 00:06 azure-pipelines[bot]

Seems the Linux build machines are running out of space No space left on device. Retrying it again, in case fluke.

fdwr avatar Jun 19 '22 01:06 fdwr

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

ytaous avatar Jul 14 '22 21:07 ytaous

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline

ytaous avatar Jul 14 '22 21:07 ytaous

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines[bot] avatar Jul 14 '22 21:07 azure-pipelines[bot]

Azure Pipelines successfully started running 8 pipeline(s).

azure-pipelines[bot] avatar Jul 14 '22 21:07 azure-pipelines[bot]

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

ytaous avatar Jul 16 '22 00:07 ytaous

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline

ytaous avatar Jul 16 '22 00:07 ytaous

Azure Pipelines successfully started running 9 pipeline(s).

azure-pipelines[bot] avatar Jul 16 '22 00:07 azure-pipelines[bot]

Azure Pipelines successfully started running 8 pipeline(s).

azure-pipelines[bot] avatar Jul 16 '22 00:07 azure-pipelines[bot]

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline

Jamather avatar Jul 21 '22 23:07 Jamather

Commenter does not have sufficient privileges for PR 11882 in repo microsoft/onnxruntime

azure-pipelines[bot] avatar Jul 21 '22 23:07 azure-pipelines[bot]

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline

fdwr avatar Jul 21 '22 23:07 fdwr

Azure Pipelines successfully started running 8 pipeline(s).

azure-pipelines[bot] avatar Jul 21 '22 23:07 azure-pipelines[bot]

Was the change to cmake/external/onnx intentional?

skottmckay avatar Jul 24 '22 23:07 skottmckay

/azp run Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, onnxruntime-python-checks-ci-pipeline

fdwr avatar Sep 13 '22 20:09 fdwr

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

fdwr avatar Sep 13 '22 20:09 fdwr

Azure Pipelines successfully started running 8 pipeline(s).

azure-pipelines[bot] avatar Sep 13 '22 20:09 azure-pipelines[bot]

Azure Pipelines successfully started running 8 pipeline(s).

azure-pipelines[bot] avatar Sep 13 '22 20:09 azure-pipelines[bot]

Seems okay to me, but will defer to @skottmckay. Glad the pipelines finally passed!

fdwr avatar Sep 14 '22 18:09 fdwr