onnxconverter-common icon indicating copy to clipboard operation
onnxconverter-common copied to clipboard

No sdist available in pypi

Open aoguntayo opened this issue 1 month ago • 8 comments

Hello! Hello!

The last two onnxconverter-common version packages do not have a sdist released with it.

1.15.0: https://pypi.org/project/onnxconverter-common/1.15.0/#files 1.16.0: https://pypi.org/project/onnxconverter-common/1.16.0/#files

1.14.0 was the last sdist version released to pypi https://pypi.org/project/onnxconverter-common/1.14.0/#files

Our build system downstream depends on provided sdist. Is there a reason this was disabled? and if possible re-enable sdist publishing for onnxconverter-common to pypi.

Thanks

aoguntayo avatar Dec 02 '25 14:12 aoguntayo

There's also no tag for 1.16.0

aoguntayo avatar Dec 12 '25 16:12 aoguntayo

They created a tag, but just the wrong one (typo): https://github.com/microsoft/onnxconverter-common/releases/tag/v0.16.0

EmilienM avatar Dec 12 '25 17:12 EmilienM

Hi @justinchuby Could you support on this?

aoguntayo avatar Dec 15 '25 12:12 aoguntayo

They created a tag, but just the wrong one (typo): v0.16.0 (release)

Good catch 😅

justinchuby avatar Dec 15 '25 18:12 justinchuby

Hi @justinchuby Could you support on this?

I think we need to update the release pipeline for it. Could you share your use case of this package in general? (As a dependency of direct use?) We have very limited bandwidth to support this package.

justinchuby avatar Dec 15 '25 18:12 justinchuby

I think we need to update the release pipeline for it

Would updating the release pipeline also ensure sdist publishing to pypi?

Could you share your use case of this package in general?

My team in redhat scope is to build and provide wheel for this package but @jiridanek should be able to share the use case.

aoguntayo avatar Dec 16 '25 10:12 aoguntayo

We bring it in as dependency of tf2onnx; we're in the process of deciding what to do since tf2onnx is incompatible with TensorFlow 2.16+

  • https://github.com/opendatahub-io/notebooks/issues/2600#issuecomment-3423143595

jiridanek avatar Dec 16 '25 12:12 jiridanek

Thanks. I suppose we can update both packages. I believe for this package we only need to update the GitHub yaml file to create sdist then create a new release. Contributions welcomed as I cannot prioritize this given the other things I am working on. Maybe I can try copilot.

justinchuby avatar Dec 16 '25 17:12 justinchuby