o365-moodle icon indicating copy to clipboard operation
o365-moodle copied to clipboard

"Support_Microsoft_account_UPN_changes" does not convert Moodle usernames to lower case

Open mariofroeschl opened this issue 1 year ago • 3 comments

It seems the new Feature "Support_Microsoft_account_UPN_changes" (https://docs.moodle.org/401/en/Microsoft_365#Support_Microsoft_account_UPN_changes) does not correctly convert the retrieved UPN to lower case, when it should be used as Moodle username.

Example:

Precondition: Support_Microsoft_account_UPN_changes enabled User in Moodle: [email protected] Related user in Azure (UPN): [email protected]

Actual result after synch (when user tries to login): Error: "The username must be in lower case".

Expected: The plugin converts the UPN to lower case, when using it as username. -> [email protected]

Tested on Moodle 4.1.6

mariofroeschl avatar Oct 30 '23 12:10 mariofroeschl

I have issue with "Support_Microsoft_account_UPN_changes" and am trying to find why, Is there a change regarding this from OpenID Connect / auth_oidc 4.2.0 to 4.2.2?

skuti-is avatar Nov 10 '23 11:11 skuti-is

Hi @mariofroeschl

Thank you for reporting the issue. I acknowledge the issue - I managed to recreate it in my environment.

I have provided a fix in the linked PRs. They will be tested and included in the next release.

Regards, Lai

weilai-irl avatar Jan 23 '24 11:01 weilai-irl

Hi @skuti-is

UPN change support is a new feature added in release 4.2.1, so it wouldn't exist in 4.2.0 release. The feature is disabled by default.

If you have any particular question about the feature, please ask in a separate issue.

Regards, Lai

weilai-irl avatar Jan 23 '24 11:01 weilai-irl

Hi @weilai-irl

is the fix for uppercase UPN problem going to be released soon? We have lots of problems with that.

kkiiskin avatar Feb 26 '24 16:02 kkiiskin

Hi @kkiiskin

The release will happen either between 11th and 14th of March, or 8th and 12th of April, depending on how the testing goes. The testing is starting from this week. We apologise for the delay, which is caused by a some sponsored feature requests to be included in this release.

Regards, Lai

weilai-irl avatar Feb 26 '24 16:02 weilai-irl

Hi all,

The fix to this issue has been included in the releases from today.

Thank you very much for reporting the issue. Please check the latest version out and see if it works.

Regards, Lai

weilai-irl avatar Mar 11 '24 14:03 weilai-irl