in auth_oidc french translation, a mistake in cfg_field_mapping_desc text

[pmatabiau]

Hi, in auth_oidc french translation, I have found a mistake in cfg_field_mapping_desc text (< /a> with space between < and /). This break all the bloc "Data mapping". I have fixed it with language customisation Moodle tool, but I don't know where to report this error. "cfg_field_mapping_desc" isn't in lang/fr/auth_oidc.php file. We use the 3.9.8 now. But it's since at least the 3.9.7.

[weilai-irl]

Hi @pmatabiau,

you are right that the string with identifier "cfg_field_mapping_desc" doesn't exist in the French language file. Most recent language file changes were applied to English only. We have plan to update language string files for a few languages that we have capability, but this has yet been scheduled. I checked the English language string file and the default string doesn't contain the error, i.e. the tag was closed correctly. So in standard installation without customisation, I suppose this should work. Please let me know if you see different.

Lai

[pmatabiau]

Hi, no, in standard installation without customisation (in french), this don't work. We needed to customise the french text to fix it (see image below). That didn't use the English text. Without this fix, all the bloc "Data mapping" is a link, and unfortunately it prevents to use fields (you can customise English text to see). I don't know where the standart FR translation comes from since the key is not in the plugin language file. If we know that, maybe we can report this error at the good place :-)

If this key is in the plugin language file, is it used in priority ?

[weilai-irl]

Hi @pmatabiau,

Could you specify the exact version auth_oidc where you see this please. I checked all recent releases of auth_oidc for Moodle 3.9 and I don't see it in the French language string files in any of the versions.

• release 3.9.8, 2020071541, https://github.com/microsoft/o365-moodle/blob/v20211207_m39/auth/oidc/lang/fr/auth_oidc.php
• release 3.9.7, 2020071535, https://github.com/microsoft/o365-moodle/blob/v20211026_v39/auth/oidc/lang/fr/auth_oidc.php
• release 3.9.5, 2020071506, https://github.com/microsoft/o365-moodle/blob/v20210702_m39/auth/oidc/lang/fr/auth_oidc.php
• release 3.9.4, 2020071504, https://github.com/microsoft/o365-moodle/blob/v20210326_m39/auth/oidc/lang/fr/auth_oidc.php
• release 3.9.3, 2020071503, https://github.com/microsoft/o365-moodle/blob/v20210128_m39/auth/oidc/lang/fr/auth_oidc.php

Regards, Lai

[pmatabiau]

It's not in the plugin. It's in language tool in Moodle admin (/admin/tool/customlang/index.php). I know it's not in any version of auth_oidc. I think I found where comes from : It's come from AMOS, the collaborative translate tool of Moodle communauty (https://lang.moodle.org/?lang=en). With an account, you can see historic of text here (I add screenshot below). English text have changed begin of december, and the French translation has finally been corrected.. but only for Moodle 3.10+. When you see the editing interface, you understand where the error comes from. It's exactly at the change of line

So, maybe you can ask if you have the right to import AMOS translation directly in your plugin file ?

---

Historique :

[weilai-irl]

Hi @pmatabiau,

I'm afraid we don't have enough resource to import translated language string from atom to the plugin. We effectively need to verify that all translations are correct. Instead, I have submitted a change in atom just to fix this error. I hope it will get approved soon, so all you need to do is to update the language pack.

This seems to be most realistic solution for now, I'm afraid.

Regards, Lai

[pmatabiau]

Hi Lai, good :-) thank you. I don't know how the version works in AMOS, if the text of a previous version can be fixed. But maybe this ticket can help who use Moodle 3.9 and OpenId. For us, simply fix the text in the Moodle language tool (key cfg_field_mapping_desc) is enough, waiting for the next update of our Moodle. Probably we need remove this customisation after the update. For us, this issue can be closed. brgs