return in finally swallows exceptions

[iritkatriel]

In https://github.com/microsoft/nutter/blob/368248bb3c2ed88a60ba6f5953b89fcc2cd0364e/common/api.py#L296 there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if a BaseException (such as KeyboardInterrupt) is raised from the body, or any exception is raised from one of the except: clauses, it will not propagate on as expected.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.