node-pty icon indicating copy to clipboard operation
node-pty copied to clipboard

Revert "chore: remove deprecated api `process.binding` (#653)"

Open devm33 opened this issue 2 months ago • 1 comments

This reverts commit 391347926a45bb0b9e2c9a9f837adc56592b3c4b.

Since the terminal write method has no way to communicate backpressure to the caller and doesn't handle it internally, quickly successive calls to write or calls with long enough data can cause a loop where the node process gets stuck repeatedly trying to write data that the terminal process did not read quickly enough.

https://github.com/microsoft/node-pty/blob/24b53bbf573ed7ab35f8897aa8b690dbd9064fc9/src/interfaces.ts#L25

Fixes https://github.com/microsoft/node-pty/issues/797

devm33 avatar Sep 18 '25 05:09 devm33