navcontainerhelper icon indicating copy to clipboard operation
navcontainerhelper copied to clipboard

Add extra parameters to Resolve-DependenciesFromAzureFeed

Open Arthurvdv opened this issue 2 years ago • 3 comments

Using the Resolve-DependenciesFromAzureFeed in our Azure DevOps pipelines I would like to expand this function with two extra parameters:

  • ignoreAppVersion
  • ignoredPublishers

ignoreAppVersion Would like to retrieve the most up-to-date version from Azure Feed and ignore the specific version from the app.json

ignoredPublishers Some Apps aren't in our Azure Feed. Based on the Publisher would like to exclude these from trying to download.

Arthurvdv avatar Aug 29 '22 07:08 Arthurvdv

CLA assistant check
All CLA requirements met.

ghost avatar Aug 29 '22 07:08 ghost

@Arthurvdv looks good. I never thought about ignoring publisher but thats a very good idea.

jonaswre avatar Aug 29 '22 08:08 jonaswre

In my latest PR I used a diffrent technique for filtering dependencies. That might be a better solution here as well. I pass a filter thats then used by Where-Object. That allows you to filter on any attribute thats in json.

https://github.com/jonaswre/navcontainerhelper/blob/e920c13e3cb5ec3a9b4ae161a1d72b5746a273b1/AppHandling/Get-DependencyGraph.ps1#L240

jonaswre avatar Aug 29 '22 11:08 jonaswre