napajs icon indicating copy to clipboard operation
napajs copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Build warning in latest node version (MSVC2017 + Node8.3.0)

Open fs-eire opened this issue 8 years ago • 3 comments

....cmake-js\node-x64\v8.3.0\include\node\v8.h(4150): warning C4251: 'v8::WasmModuleObjectBuilder::received_buffers_': class 'std::vector<v8::WasmModuleObjectBuilder::Buffer,std::allocator<_Ty>>' needs to have dll-interface to be used by clients of class 'v8::WasmModuleObjectBuilder'

fs-eire avatar Aug 15 '17 05:08 fs-eire

It looks good in linux/MacOS. Seems a MSVC specific issue.

fs-eire avatar Aug 15 '17 05:08 fs-eire

This is being discussed in https://github.com/nodejs/node/pull/15570.

fs-eire avatar Jan 02 '18 21:01 fs-eire

It would be great if this could be fixed.

BridgeAR avatar Jan 31 '18 01:01 BridgeAR