muzic icon indicating copy to clipboard operation
muzic copied to clipboard

[teleMelody] How to modify the tonality in the inference code?

Open elricwan opened this issue 2 years ago • 3 comments

Hi there, Thank you first for providing the great checkpoints so that I can play with some examples. During the experiments, I notice that I could modify the chord file to control the chord progression. From the paper, I also notice that the tonality could be controlled, but I did not find a place to modify this value. so how could we control the tonality during inference?

Thank you.

elricwan avatar Sep 19 '22 16:09 elricwan

Hi @elricwan . You can modify the mode variable ( MAJ or MIN ) in the code to control the tonality during inference.

jzq2000 avatar Sep 23 '22 02:09 jzq2000

Hi @jzq2000 ,Thank you for the explanation! By the way, there are many more tonality exists like C, D, E, F, G, etc. Is there a specific reason that teleMelody trained on the C major and A minor tonality?

Thank you.

elricwan avatar Sep 23 '22 15:09 elricwan

@elricwan Yes. It is a common trick since transposition (other majors to C major / other minors to A minor) is trivial and rule-based. Thus, we need to consider one specific major and one specific minor, and normalize other tonalities to these two.

jzq2000 avatar Sep 24 '22 01:09 jzq2000