mu icon indicating copy to clipboard operation
mu copied to clipboard

Consolidate the multiple copies of UefiVariablesSupportLib.py in MU_PLUS

Open out0xb2 opened this issue 4 years ago • 3 comments

There are 2 copies of UefiVariablesSupportLib.py in MU_PLUS.

  1. UefiTestingPkg copy
  2. DfciPkg copy

Consider consolidation or move to a PyTools Library?

out0xb2 avatar May 05 '20 16:05 out0xb2

Ewww... I thought that already was in one of the edk2tools packages? If not, yes, we should move it.

corthon avatar Jun 04 '20 22:06 corthon

I feel like you could also make the case that this belongs in pytool extensions. But yes. I strongly agree this should be in one of the pytools

matthewfcarlson avatar Jun 04 '20 22:06 matthewfcarlson

So we have talked about adding somethign like this https://github.com/microsoft/mu_plus/blob/release/202002/UefiTestingPkg/AuditTests/UefiVarLockAudit/Windows/UefiVariablesSupportLib.py to a location like here: https://github.com/tianocore/edk2-pytool-library/tree/master/edk2toollib/windows

But this code carries significant dependencies. It needs access to win32apis. This requires installing other modules some of which are not small.

spbrogan avatar Jun 05 '20 19:06 spbrogan

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Dec 02 '22 23:12 github-actions[bot]

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

github-actions[bot] avatar Dec 09 '22 23:12 github-actions[bot]