mu icon indicating copy to clipboard operation
mu copied to clipboard

Improve the readability and reduce brittleness of Variable Services "bucket" logic

Open corthon opened this issue 2 years ago • 2 comments

You can see perhaps the worst offender here: https://github.com/microsoft/mu_basecore/blob/c4d0d1130454b3e5051bb601c707234e3a91713a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c#L2185

But the idea is to wrap each of these tests in a descriptive macro or function so that it's more readable AND we don't have to change multiple places if we ever change the logic (like adding a new PCD).

Example: WillVarExceedHwErrQuota( VarSize );, or something like that.

corthon avatar May 10 '22 05:05 corthon

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Nov 29 '22 01:11 github-actions[bot]