Incremental build error

[charvatjiri]

Hello, it was reported by one of our customers, that incremental build does not work. We tracked it down to the GNUmakefile RELEASE_GCC5/AARCH64/ArmPlatformPkg/PrePi/PeiUniCore/GNUmakefile where a dependency is missing: instead of:

$(FFS_OUTPUT_DIR)/$(MODULE_GUID).efi : test -f $(OUTPUT_DIR)/ArmPlatformPrePiUniCore.efi && $(CP) $(OUTPUT_DIR)/ArmPlatformPrePiUniCore.efi $(FFS_OUTPUT_DIR)/$(MODULE_GUID).efi

the incremental build works fine with:

$(FFS_OUTPUT_DIR)/$(MODULE_GUID).efi : $(OUTPUT_DIR)/ArmPlatformPrePiUniCore.efi test -f $(OUTPUT_DIR)/ArmPlatformPrePiUniCore.efi && $(CP) $(OUTPUT_DIR)/ArmPlatformPrePiUniCore.efi $(FFS_OUTPUT_DIR)/$(MODULE_GUID).efi

It means that copy will happen not only if the destination file is missing, but also if the source file (=makefile rule dependency) has changed. (Possibly similar issue for *.map file above in the same GNUmakefile). I can provide more details if needed, and can debug the whole GNUmakefile generation process in mu_basecore/BaseTools/Source/Python. But it is too big to debug for external person so hopefully somebody can look into it. Can this be fixed?

[spbrogan]

Opened bug with tianocore https://github.com/tianocore/edk2-basetools/issues/38

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

[github-actions[bot]]

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

[bcran]

@charvatjiri The message appears to have been pretty badly mangled by misinterpreting characters as markdown. Could you re-post the message in https://github.com/tianocore/edk2-basetools/issues/38 surrounded by three backticks to have it formatted as plain text please?

e.g.: ``` Put the text here ```

This will allow _text_ *which* would otherwise be interpreted as markdown including & ^ * % $ # to appear without formatting.